From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/4] drm/i915/gtt: Reference mappable_end variable from pointer
Date: Fri, 18 Mar 2016 10:46:57 +0000 [thread overview]
Message-ID: <56EBDCA1.2070704@linux.intel.com> (raw)
In-Reply-To: <1458290579-27783-1-git-send-email-joonas.lahtinen@linux.intel.com>
On 18/03/16 08:42, Joonas Lahtinen wrote:
> Reference variable value from pointer, not assumed pointer destination.
>
> Since:
>
> commit c44ef60e437019b8ca1dab8b4d2e8761fd4ce1e9
> Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Date: Thu Jun 25 18:35:05 2015 +0300
>
> drm/i915/gtt: Allow >= 4GB sizes for vm.
>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 9c752fe..5c90952 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -3103,8 +3103,7 @@ static int gen6_gmch_probe(struct drm_device *dev,
> * a coarse sanity check.
> */
> if ((*mappable_end < (64<<20) || (*mappable_end > (512<<20)))) {
> - DRM_ERROR("Unknown GMADR size (%llx)\n",
> - dev_priv->gtt.mappable_end);
> + DRM_ERROR("Unknown GMADR size (%llx)\n", *mappable_end);
> return -ENXIO;
> }
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-18 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 8:42 [PATCH v2 1/4] drm/i915/gtt: Reference mappable_end variable from pointer Joonas Lahtinen
2016-03-18 8:42 ` [PATCH v2 2/4] drm/i915: Rename dev_priv->gtt to dev_priv->ggtt Joonas Lahtinen
2016-03-18 8:42 ` [PATCH v2 3/4] drm/i915/gtt: Clean up GGTT probing code Joonas Lahtinen
2016-03-18 8:42 ` [PATCH v2 4/4] drm/i915: Codify our assumption that the Global GTT is <= 4GiB Joonas Lahtinen
2016-03-18 10:56 ` Tvrtko Ursulin
2016-03-18 11:08 ` Chris Wilson
2016-03-18 12:39 ` Mika Kuoppala
2016-03-18 12:48 ` Mika Kuoppala
2016-03-18 10:46 ` Tvrtko Ursulin [this message]
2016-03-18 12:11 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/4] drm/i915/gtt: Reference mappable_end variable from pointer Patchwork
2016-03-18 12:56 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EBDCA1.2070704@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox