From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: Do not check crtc_state->active in intel_color_load_luts.
Date: Wed, 30 Mar 2016 17:42:55 +0100 [thread overview]
Message-ID: <56FC020F.9090508@intel.com> (raw)
In-Reply-To: <1459350996-4957-3-git-send-email-maarten.lankhorst@linux.intel.com>
On 30/03/16 16:16, Maarten Lankhorst wrote:
> This is already tested by its callers.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/intel_color.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
> index 9cffa638c351..1b3f97449395 100644
> --- a/drivers/gpu/drm/i915/intel_color.c
> +++ b/drivers/gpu/drm/i915/intel_color.c
> @@ -487,10 +487,6 @@ void intel_color_load_luts(struct drm_crtc_state *crtc_state)
> struct drm_device *dev = crtc_state->crtc->dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
>
> - /* The clocks have to be on to load the palette. */
> - if (!crtc_state->active)
> - return;
> -
> dev_priv->display.load_luts(crtc_state);
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-30 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:16 [PATCH 0/3] drm/i915: color management atomic fixes Maarten Lankhorst
2016-03-30 15:16 ` [PATCH 1/3] drm/i915: Pass crtc_state to color management functions Maarten Lankhorst
2016-03-30 16:44 ` Lionel Landwerlin
2016-03-30 15:16 ` [PATCH 2/3] drm/i915: Do not check crtc_state->active in intel_color_load_luts Maarten Lankhorst
2016-03-30 16:42 ` Lionel Landwerlin [this message]
2016-03-30 15:16 ` [PATCH 3/3] drm/i915: Update color management during vblank evasion Maarten Lankhorst
2016-03-30 16:41 ` Lionel Landwerlin
2016-03-31 10:35 ` Lionel Landwerlin
2016-03-31 10:35 ` Lionel Landwerlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC020F.9090508@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox