From: Dave Gordon <david.s.gordon@intel.com>
To: Eric Engestrom <eric@engestrom.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 4/5] tests: fix spelling mistakes
Date: Mon, 4 Apr 2016 10:49:01 +0100 [thread overview]
Message-ID: <5702388D.3010804@intel.com> (raw)
In-Reply-To: <1459701330-2263-4-git-send-email-eric@engestrom.ch>
On 03/04/16 17:35, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <eric@engestrom.ch>
> ---
> tests/gem_concurrent_all.c | 2 +-
> tests/gem_cpu_reloc.c | 2 +-
> tests/gem_flink_race.c | 2 +-
> tests/gem_seqno_wrap.c | 2 +-
> tests/gem_tiled_wb.c | 2 +-
> tests/prime_nv_api.c | 2 +-
> tests/prime_nv_pcopy.c | 2 +-
> tests/prime_self_import.c | 4 ++--
> 8 files changed, 9 insertions(+), 9 deletions(-)
[snip]
> diff --git a/tests/prime_nv_api.c b/tests/prime_nv_api.c
> index 054a1ec..6bf891a 100644
> --- a/tests/prime_nv_api.c
> +++ b/tests/prime_nv_api.c
> @@ -1,4 +1,4 @@
> -/* wierd use of API tests */
> +/* weird use of API tests */
>
> /* test1- export buffer from intel, import same fd twice into nouveau,
> check handles match
> diff --git a/tests/prime_nv_pcopy.c b/tests/prime_nv_pcopy.c
> index b5ceabf..99eaeea 100644
> --- a/tests/prime_nv_pcopy.c
> +++ b/tests/prime_nv_pcopy.c
> @@ -673,7 +673,7 @@ static void check3(const uint32_t *p, uint32_t pitch, uint32_t lines,
> }
> }
>
> -/* copy from nvidia bo to intel bo and copy to a linear bo to check if tiling went succesful */
> +/* copy from nvidia bo to intel bo and copy to a linear bo to check if tiling went successful */
Might as well correct the grammar here too - I'd suggest "was
successful", or else "went successfully", but the latter still seems
rather clumsy.
Apart from that, they all look good, so
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
IIRC there's a tool ("codespell"?) that can help find these typos;
perhaps it would be worth adding the most recurrent of them (e,g,
intruction->instruction) to the dictionary?
.Dave.
PS: Found the tool: https://github.com/lucasdemarchi/codespell
Dictionary is /usr/share/codespell/dictionary.txt
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-04 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 16:35 [PATCH i-g-t 1/5] README: fix spelling mistakes Eric Engestrom
2016-04-03 16:35 ` [PATCH i-g-t 2/5] assembler: " Eric Engestrom
2016-04-03 16:35 ` [PATCH i-g-t 3/5] lib: " Eric Engestrom
2016-04-03 16:35 ` [PATCH i-g-t 4/5] tests: " Eric Engestrom
2016-04-04 9:49 ` Dave Gordon [this message]
2016-04-03 16:35 ` [PATCH i-g-t 5/5] tools: " Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5702388D.3010804@intel.com \
--to=david.s.gordon@intel.com \
--cc=eric@engestrom.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox