From: Dave Gordon <david.s.gordon@intel.com>
To: tim.gore@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport
Date: Tue, 19 Apr 2016 17:17:43 +0100 [thread overview]
Message-ID: <57165A27.8020109@intel.com> (raw)
In-Reply-To: <1461077152-31899-1-git-send-email-tim.gore@intel.com>
On 19/04/16 15:45, tim.gore@intel.com wrote:
> From: Tim Gore <tim.gore@intel.com>
>
> WaEnableSamplerGPGPUPreemptionSupport fixes a problem
> related to mid thread pre-emption.
>
> Signed-off-by: Tim Gore <tim.gore@intel.com>
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 1 +
> drivers/gpu/drm/i915/intel_ringbuffer.c | 7 ++++---
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 9464ba3..2982470b 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7162,6 +7162,7 @@ enum skl_disp_power_wells {
>
> #define GEN9_HALF_SLICE_CHICKEN7 _MMIO(0xe194)
> #define GEN9_ENABLE_YV12_BUGFIX (1<<4)
> +#define GEN9_ENABLE_GPGPU_PREEMPTION (1<<2)
>
> /* Audio */
> #define G4X_AUD_VID_DID _MMIO(dev_priv->info.display_mmio_offset + 0x62020)
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 0d24494..444d30a 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -959,9 +959,10 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
> }
>
> /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt */
> - if (IS_SKL_REVID(dev, SKL_REVID_C0, REVID_FOREVER) || IS_BROXTON(dev))
> - WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> - GEN9_ENABLE_YV12_BUGFIX);
> + /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt */
> + WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> + GEN9_ENABLE_YV12_BUGFIX |
> + GEN9_ENABLE_GPGPU_PREEMPTION);
>
> /* Wa4x4STCOptimizationDisable:skl,bxt */
> /* WaDisablePartialResolveInVc:skl,bxt */
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-19 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 14:45 [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport tim.gore
2016-04-19 15:54 ` ✓ Fi.CI.BAT: success for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4) Patchwork
2016-04-20 9:03 ` Tvrtko Ursulin
2016-04-19 16:17 ` Dave Gordon [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-12 14:22 [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport tim.gore
2016-04-07 9:38 tim.gore
2016-04-06 9:28 tim.gore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57165A27.8020109@intel.com \
--to=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tim.gore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox