From: Robert Foss <robert.foss@collabora.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Fwd: Re: [RFC i-g-t 6/7] demos/Makefile: Don't build tools that depend on libdrm_intel.
Date: Wed, 25 May 2016 18:07:13 -0400 [thread overview]
Message-ID: <57462211.30103@collabora.com> (raw)
In-Reply-To: <2b8f-57460580-7-7d43af80@249225208>
On Wednesday, May 25, 2016 19:18 BST, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> Use the HAS_INTEL automake flag to avoid building tools that won't
> compile unless libdrm_intel is available in the build system.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
> demos/Android.mk | 5 ++++-
> demos/Makefile.am | 8 +++++---
> demos/Makefile.sources | 7 +++++++
> 3 files changed, 16 insertions(+), 4 deletions(-)
> create mode 100644 demos/Makefile.sources
>
> diff --git a/demos/Android.mk b/demos/Android.mk
> index 7d06c9a..add2414 100644
> --- a/demos/Android.mk
> +++ b/demos/Android.mk
> @@ -4,8 +4,11 @@ LOCAL_PATH := $(call my-dir)
>
> include $(CLEAR_VARS)
>
> -LOCAL_SRC_FILES := intel_sprite_on.c
> +LOCAL_SRC_FILES :=
>
> +ifeq ($(HAVE_LIBDRM_INTEL),true)
> + LOCAL_SRC_FILES += $(LIBDRM_INTEL_BIN)
> +endif
>
Note for the future, you don't have to do anything.
As/if one tries to get IGT on Android without libdrm_intel and there
aren't any non-intel demos, the guard should cover the whole file. I
doubt their build system will be happy if you request a program with no
sources and just static library.
-Emil
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
parent reply other threads:[~2016-05-25 22:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2b8f-57460580-7-7d43af80@249225208>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57462211.30103@collabora.com \
--to=robert.foss@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox