From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v3 0/4] Wait PSR idle before on dsb commit
Date: Mon, 8 Sep 2025 07:32:09 +0000 [thread overview]
Message-ID: <58313353b8698da15d046981d9346154c49c22cc.camel@intel.com> (raw)
In-Reply-To: <20250905072708.2659411-1-jouni.hogander@intel.com>
On Fri, 2025-09-05 at 10:27 +0300, Jouni Högander wrote:
> We are currently observing crc failures after we started using dsb
> for PSR
> updates as well. This seems to happen because PSR HW is still sending
> couple of updates using old framebuffers on wake-up.
>
> On non-dsb commit we are waiting PSR HW to idle before starting a new
> commit. Fix problems with dsb commit by adding similar wait on dsb
> commit as well.
>
> v3: add intel_dsb as a parameter to intel_psr_wait_for_idle_dsb
> v2: add pass crtc_state->dsb_commit as parameter
>
> Jouni Högander (4):
> drm/i915/psr: Pass intel_crtc_state instead of intel_dp in
> wait_for_idle
> drm/i915/psr: Add new define for PSR idle timeout
> drm/i915/psr: New interface adding PSR idle poll into dsb commit
> drm/i915/psr: Add poll for checking PSR is idle before starting
> update
>
> drivers/gpu/drm/i915/display/intel_display.c | 3 +
> drivers/gpu/drm/i915/display/intel_psr.c | 69 +++++++++++++++---
> --
> drivers/gpu/drm/i915/display/intel_psr.h | 2 +
> 3 files changed, 58 insertions(+), 16 deletions(-)
>
Thank you Ville and Mika for your reviews. This is now pushed to drm-
intel-next.
BR,
Jouni Högander
prev parent reply other threads:[~2025-09-08 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 7:27 [PATCH v3 0/4] Wait PSR idle before on dsb commit Jouni Högander
2025-09-05 7:27 ` [PATCH v3 1/4] drm/i915/psr: Pass intel_crtc_state instead of intel_dp in wait_for_idle Jouni Högander
2025-09-05 7:27 ` [PATCH v3 2/4] drm/i915/psr: Add new define for PSR idle timeout Jouni Högander
2025-09-05 7:27 ` [PATCH v3 3/4] drm/i915/psr: New interface adding PSR idle poll into dsb commit Jouni Högander
2025-09-05 7:27 ` [PATCH v3 4/4] drm/i915/psr: Add poll for checking PSR is idle before starting update Jouni Högander
2025-09-05 9:17 ` Ville Syrjälä
2025-09-05 16:17 ` ✓ i915.CI.BAT: success for Wait PSR idle before on dsb commit (rev3) Patchwork
2025-09-06 7:55 ` ✗ i915.CI.Full: failure " Patchwork
2025-09-08 4:43 ` Hogander, Jouni
2025-09-08 7:32 ` Hogander, Jouni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58313353b8698da15d046981d9346154c49c22cc.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox