Re: [PATCH] drm/i915: Re-enable aliasing PPGTT mode.

From: Zhi Wang <zhi.a.wang@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Michal Winiarski <michal.winiarski@intel.com>,
	Michel Thierry <michel.thierry@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>,
	Zhiyuan Lv <zhiyuan.lv@intel.com>
Subject: Re: [PATCH] drm/i915: Re-enable aliasing PPGTT mode.
Date: Mon, 06 Feb 2017 16:18:23 +0800	[thread overview]
Message-ID: <5898314F.5010505@intel.com> (raw)
In-Reply-To: <20170206081024.GA28323@nuc-i3427.alporthouse.com>

Hi Chris:
     Thanks for the reply! :P Have you also fixed here with your new ideas?

in intel_lrc:

static u64 execlists_update_context(struct drm_i915_gem_request *rq)
{
         struct intel_context *ce = &rq->ctx->engine[rq->engine->id];
         struct i915_hw_ppgtt *ppgtt = rq->ctx->ppgtt;  // ----> check 
if we should get ppgtt from dev_priv->mm.aliasing_ppgtt.

         u32 *reg_state = ce->lrc_reg_state;

         reg_state[CTX_RING_TAIL+1] = rq->tail;


On 02/06/17 16:10, Chris Wilson wrote:
>> - Load the root pointers of the PPGTT page table during the context
>> >initialization, as currently the "LRI PDPs updating" magic only works
>> >under full PPGTT mode and also GVT-g doesn't support LRI PDP updating.
> That is incorrect, they are loaded into the context image before
> submission. If you want to make sure they are unchanging so that
> lite-restore under g-GVT works, that is another matter.
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx