From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 RESEND] drm/i915: prefer INTEL_GEN() over INTEL_INFO()->gen
Date: Thu, 26 Apr 2018 12:39:03 +0100 [thread overview]
Message-ID: <5b52cbc3-97d9-252f-ff96-a1eae86042fe@linux.intel.com> (raw)
In-Reply-To: <20180426113521.28417-1-jani.nikula@intel.com>
On 26/04/2018 12:35, Jani Nikula wrote:
> Prefer INTEL_GEN() over INTEL_INFO()->gen except in special
> circumstances.
>
> v2: don't change device info dump (Chris)
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_device_info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a32ba72c514e..0fd13df424cf 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -848,7 +848,7 @@ void intel_device_info_runtime_init(struct intel_device_info *info)
> gen9_sseu_info_init(dev_priv);
> else if (INTEL_GEN(dev_priv) == 10)
> gen10_sseu_info_init(dev_priv);
> - else if (INTEL_INFO(dev_priv)->gen >= 11)
> + else if (INTEL_GEN(dev_priv) >= 11)
> gen11_sseu_info_init(dev_priv);
>
> /* Initialize command stream timestamp frequency */
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-04-26 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 11:35 [PATCH v2 RESEND] drm/i915: prefer INTEL_GEN() over INTEL_INFO()->gen Jani Nikula
2018-04-26 11:39 ` Tvrtko Ursulin [this message]
2018-04-26 15:18 ` Jani Nikula
2018-04-26 12:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-26 14:14 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b52cbc3-97d9-252f-ff96-a1eae86042fe@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox