Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Peter Clifton <pcjc2@cam.ac.uk>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"mesa3d-dev@lists.sourceforge.net"
	<mesa3d-dev@lists.sourceforge.net>
Subject: Re: [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits
Date: Sun, 07 Nov 2010 10:25:52 +0000	[thread overview]
Message-ID: <5b55a1$ijc3pt@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1289037871.2453.3.camel@pcjc2lap>

On Sat, 06 Nov 2010 10:04:31 +0000, Peter Clifton <pcjc2@cam.ac.uk> wrote:
> Fixes corruption with glBufferSubData on my machine,
> 
> Can someone review and push?

Oddly, the pitch for BLT is in bytes and it should be sufficient to be a
multiple of element-size. Or two element-size depending on circumstances. 

Just to satisfy my curiosity, what happens with (1<<15 - 2)?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2010-11-07 10:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 10:04 [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits Peter Clifton
2010-11-07 10:25 ` Chris Wilson [this message]
2010-11-09 10:52   ` Peter Clifton
2010-11-09 11:34     ` Peter Clifton
2010-11-09 11:43       ` Chris Wilson
  -- strict thread matches above, loose matches on Subject: below --
2010-11-06  9:23 Peter Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='5b55a1$ijc3pt@fmsmga002.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mesa3d-dev@lists.sourceforge.net \
    --cc=pcjc2@cam.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox