From: Chris Wilson <chris@chris-wilson.co.uk>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: pipe control notify removed?
Date: Wed, 15 Dec 2010 10:05:01 +0000 [thread overview]
Message-ID: <5b55a1$iv0q2i@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20101215031453.GA29548@zhen-devel.sh.intel.com>
On Wed, 15 Dec 2010 11:14:53 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
>
> Chris, just notice you removed pipe control notify entirely on -next,
> that seems wrong to me. In Ironlake time, we've seen interrupt stall issue
> with user interrupt, and be warned user interrupt is deprecated, so we moved
> on to use pipe control notify, although there's a workaround later covered
> that's required on Ironlake. But it's stable finally. And for sandybridge,
> there's no such workaround needed.
The answer to this is to make sure that such details are kept in the
code comments, especially if such information is not readily available
in the documentation.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-12-15 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 3:14 pipe control notify removed? Zhenyu Wang
2010-12-15 3:22 ` Shuang He
2010-12-15 10:05 ` Chris Wilson [this message]
2010-12-16 1:59 ` Zhenyu Wang
2010-12-16 2:23 ` Fu Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5b55a1$iv0q2i@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox