From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/8] drm/i915: Move register white-listing to the common workaround framework
Date: Fri, 30 Nov 2018 15:16:52 +0000 [thread overview]
Message-ID: <5bc106ba-e149-b2c8-0b95-3213b65c103f@linux.intel.com> (raw)
In-Reply-To: <154357835061.20153.375665797722722545@skylake-alporthouse-com>
On 30/11/2018 11:45, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-11-30 11:31:59)
>> -static void whitelist_reg(struct whitelist *w, i915_reg_t reg)
>> +static void
>> +whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)
>> {
>> - if (GEM_DEBUG_WARN_ON(w->count >= RING_MAX_NONPRIV_SLOTS))
>> - return;
>> -
>> - w->reg[w->count++] = reg;
>> -}
>> + struct i915_wa wa = {
>> + .reg = reg
>> + };
>>
>> -static void bdw_whitelist_build(struct whitelist *w)
>> -{
>> -}
>> + if (GEM_WARN_ON(wal->count >= RING_MAX_NONPRIV_SLOTS))
>
> We only need this code for pre-merge testing of patches as the build
> list is static.
I interpret this as change to GEM_DEBUG_WARN_ON - makes sense.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-30 15:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 11:31 [PATCH 0/8] Restore workarounds after engine reset and unify their handling Tvrtko Ursulin
2018-11-30 11:31 ` [PATCH 1/8] drm/i915: Record GT workarounds in a list Tvrtko Ursulin
2018-11-30 11:31 ` [PATCH 2/8] drm/i915: Introduce per-engine workarounds Tvrtko Ursulin
2018-11-30 11:31 ` [PATCH 3/8] drm/i915: Verify GT workaround state at runtime Tvrtko Ursulin
2018-11-30 11:38 ` Chris Wilson
2018-11-30 12:02 ` Tvrtko Ursulin
2018-11-30 14:36 ` Chris Wilson
2018-11-30 11:54 ` Chris Wilson
2018-11-30 15:21 ` Tvrtko Ursulin
2018-11-30 11:31 ` [PATCH 4/8] drm/i915: Verify engine " Tvrtko Ursulin
2018-11-30 11:31 ` [PATCH 5/8] drm/i915/selftests: Add tests for GT and engine workaround verification Tvrtko Ursulin
2018-11-30 11:43 ` Chris Wilson
2018-11-30 15:15 ` Tvrtko Ursulin
2018-11-30 15:21 ` Chris Wilson
2018-11-30 11:31 ` [PATCH 6/8] drm/i915: Move register white-listing to the common workaround framework Tvrtko Ursulin
2018-11-30 11:45 ` Chris Wilson
2018-11-30 15:16 ` Tvrtko Ursulin [this message]
2018-11-30 11:32 ` [PATCH 7/8] drm/i915: Fuse per-context workaround handling with the common framework Tvrtko Ursulin
2018-11-30 11:47 ` Chris Wilson
2018-11-30 15:17 ` Tvrtko Ursulin
2018-11-30 11:32 ` [PATCH 8/8] drm/i915: Trim unused workaround list entries Tvrtko Ursulin
2018-11-30 11:49 ` Chris Wilson
2018-11-30 15:18 ` Tvrtko Ursulin
2018-11-30 12:06 ` ✗ Fi.CI.BAT: failure for Restore workarounds after engine reset and unify their handling Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc106ba-e149-b2c8-0b95-3213b65c103f@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox