Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "Mun, Gwan-gyeong" <gwan-gyeong.mun@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0
Date: Thu, 22 Apr 2021 16:07:19 +0000	[thread overview]
Message-ID: <5ca39ff25c365ef7d2db753c7886c7c0cd956e7a.camel@intel.com> (raw)
In-Reply-To: <20210422160544.2427123-1-gwan-gyeong.mun@intel.com>

On Thu, 2021-04-22 at 19:05 +0300, Gwan-gyeong Mun wrote:
> TGL PSR2 hardware tracking shows momentary flicker and screen shift if
> TGL Display stepping is B1 from A0.
> It has been fixed from TGL Display stepping C0.
> 
> HSDES: 18015970021
> HSDES: 2209313811
> BSpec: 55378
> 
> v2: Add checking of PSR2 manual tracking (Jose)
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 4ad756e238c5..17cbdd7805a2 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -817,6 +817,13 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
>  		}
>  	}
>  
> 
> 
> 
> +	/* Wa_2209313811 */
> +	if (!crtc_state->enable_psr2_sel_fetch &&
> +	    IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B1)) {
> +		drm_dbg_kms(&dev_priv->drm, "PSR2 HW tracking is not supported this Display stepping\n");
> +		return false;
> +	}
> +
>  	if (!crtc_state->enable_psr2_sel_fetch &&
>  	    (crtc_hdisplay > psr_max_h || crtc_vdisplay > psr_max_v)) {
>  		drm_dbg_kms(&dev_priv->drm,

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-04-22 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 16:05 [Intel-gfx] [PATCH v2] drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0 Gwan-gyeong Mun
2021-04-22 16:07 ` Souza, Jose [this message]
2021-04-22 16:29 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0 (rev2) Patchwork
2021-04-22 16:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-22 20:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-23 10:04 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0 (rev3) Patchwork
2021-04-23 10:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-04-26 17:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0 (rev4) Patchwork
2021-04-26 23:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-27  0:00   ` Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ca39ff25c365ef7d2db753c7886c7c0cd956e7a.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox