From: Michel Thierry <michel.thierry@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename).
Date: Mon, 4 Dec 2017 16:09:35 -0800 [thread overview]
Message-ID: <5cbc64a5-1eee-208a-6cf1-5035d2ae36fb@intel.com> (raw)
In-Reply-To: <20171205000415.31868-1-rodrigo.vivi@intel.com>
On 12/4/2017 4:04 PM, Rodrigo Vivi wrote:
> When commit '82daca297506 ("drm/i915: Add "panel orientation"
> property to the panel connector, v6.")' was done and tested
> by CI, commit 'ed15030d7ab0 ("drm/i915: s/enum plane/enum
> i9xx_plane_id/")' wasn't there already.
>
> On this race the second patch got merged first so the first one
> broke i915 compilation. Thanks to Michel this was found quickly.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Suggested-by: Michel Thierry <michel.thierry@intel.com>
> Fixes: 82daca297506 ("drm/i915: Add "panel orientation" property to the panel connector, v6.")
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 1b60df3c14a0..f67d321376e4 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -1670,7 +1670,7 @@ static int intel_dsi_get_panel_orientation(struct intel_connector *connector)
> {
> struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
> int orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL;
> - enum plane plane;
> + enum i9xx_plane_id plane;
> u32 val;
>
> if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
>
Reviewed-by: Michel Thierry <michel.thierry@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-05 0:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 0:04 [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename) Rodrigo Vivi
2017-12-05 0:09 ` Michel Thierry [this message]
2017-12-05 0:58 ` Rodrigo Vivi
2017-12-05 8:18 ` Hans de Goede
2017-12-05 10:12 ` Joonas Lahtinen
2017-12-05 10:14 ` Daniel Vetter
2017-12-05 10:42 ` Hans de Goede
2017-12-05 0:14 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-05 0:42 ` Rodrigo Vivi
2017-12-05 13:38 ` [PATCH] " Ville Syrjälä
2017-12-05 14:06 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cbc64a5-1eee-208a-6cf1-5035d2ae36fb@intel.com \
--to=michel.thierry@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox