From: "Govindapillai, Vinod" <vinod.govindapillai@intel.com>
To: "Murthy, Arun R" <arun.r.murthy@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Handle the DG2 max bw properly
Date: Thu, 24 Mar 2022 23:26:29 +0000 [thread overview]
Message-ID: <5dd42cd21ded7bb83bf84836f19cef7bfabc76bf.camel@intel.com> (raw)
In-Reply-To: <DM6PR11MB317739510758294133A45FA8BA199@DM6PR11MB3177.namprd11.prod.outlook.com>
On Thu, 2022-03-24 at 08:39 +0000, Murthy, Arun R wrote:
> > }
> >
> > +static unsigned int dg2_max_bw(struct drm_i915_private *i915) {
> > + struct intel_bw_info *bi = &i915->max_bw[0];
> > +
> > + return bi->deratedbw[0];
> > +}
>
> Would it look better to have this as a macro rather than a function?
Hey Thanks for the comment!
Ideally probably yes.. I thought the function might be better here
But in any case, actually V2 for this patch is in progress. I had abandoned that extra function
instead use value directly.
> Thanks and Regards,
> Arun R Murthy
> --------------------
next prev parent reply other threads:[~2022-03-24 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 12:43 [Intel-gfx] [PATCH 0/1] [PATCH 0/1] Handle the DG2 max bw properly Vinod Govindapillai
2022-03-22 12:43 ` [Intel-gfx] [PATCH 1/1] drm/i915: " Vinod Govindapillai
2022-03-24 8:39 ` Murthy, Arun R
2022-03-24 23:26 ` Govindapillai, Vinod [this message]
2022-03-22 13:47 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2022-03-22 14:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-22 20:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd42cd21ded7bb83bf84836f19cef7bfabc76bf.camel@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox