From: James Zhu <jamesz@amd.com>
To: "Christian König" <christian.koenig@amd.com>,
"Simon Ser" <contact@emersion.fr>
Cc: "Matthew Wilcox" <willy@infradead.org>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Maxime Ripard" <mripard@kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
"James Zhu" <James.Zhu@amd.com>,
"Oded Gabbay" <ogabbay@kernel.org>
Subject: Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS
Date: Tue, 8 Aug 2023 11:04:09 -0400 [thread overview]
Message-ID: <61efe587-9a7a-063c-a388-eed9f51958d4@amd.com> (raw)
In-Reply-To: <ad26d275-4373-429f-ecaa-3e35978f1fb0@amd.com>
I would like if these kernel patches are accepted by everyone, If yes,
when they can be upstream.
I have a MR for libdrm to support drm nodes type up to 2^MINORBITS
nodes which can work with these patches,
https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/305
Thanks!
James
On 2023-08-08 09:55, Christian König wrote:
> Am 28.07.23 um 16:22 schrieb Simon Ser:
>> On Thursday, July 27th, 2023 at 14:01, Christian König
>> <christian.koenig@amd.com> wrote:
>>
>>>> We do need patches to stop trying to infer the node type from the
>>>> minor
>>>> in libdrm, though. Emil has suggested using sysfs, which we already do
>>>> in a few places in libdrm.
>>> That sounds like a really good idea to me as well.
>>>
>>> But what do we do with DRM_MAX_MINOR? Change it or keep it and say apps
>>> should use drmGetDevices2() like Emil suggested?
>> DRM_MAX_MINOR has been bumped to 64 now.
>>
>> With the new minor allocation scheme, DRM_MAX_MINOR is meaningless
>> because there is no "max minor per type" concept anymore: the minor no
>> longer contains the type.
>>
>> So I'd suggest leaving it as-is (so that old apps still continue to
>> work on systems with < 64 devices like they do today) and mark it as
>> deprecated.
>
> Sounds like a plan to me.
>
> Regards,
> Christian.
next prev parent reply other threads:[~2023-08-08 15:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 21:14 [Intel-gfx] [PATCH v6 0/4] drm: Use full allocated minor range for DRM Michał Winiarski
2023-07-24 21:14 ` [Intel-gfx] [PATCH v6 1/4] drm: Use XArray instead of IDR for minors Michał Winiarski
2023-08-25 16:59 ` James Zhu
2023-08-28 21:08 ` Michał Winiarski
2023-08-29 17:34 ` James Zhu
2023-08-29 18:33 ` Matthew Wilcox
2023-08-29 18:35 ` James Zhu
2023-08-29 18:37 ` Matthew Wilcox
2023-07-24 21:14 ` [Intel-gfx] [PATCH v6 2/4] accel: " Michał Winiarski
2023-07-24 21:14 ` [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS Michał Winiarski
2023-07-24 22:29 ` James Zhu
2023-07-26 18:15 ` Simon Ser
2023-07-27 12:01 ` Christian König
2023-07-28 14:22 ` Simon Ser
2023-08-08 13:55 ` Christian König
2023-08-08 15:04 ` James Zhu [this message]
2023-08-23 10:53 ` Simon Ser
2023-08-23 10:58 ` Simon Ser
2023-08-23 14:06 ` James Zhu
2023-07-24 21:14 ` [Intel-gfx] [PATCH v6 4/4] drm: Introduce force_extended_minors modparam Michał Winiarski
2023-07-24 21:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Use full allocated minor range for DRM (rev3) Patchwork
2023-07-24 22:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-25 6:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-30 16:31 ` [Intel-gfx] [PATCH v6 0/4] drm: Use full allocated minor range for DRM James Zhu
2024-05-03 1:22 ` Eric Pilmore
2024-08-12 17:38 ` Alex Deucher
2024-08-14 0:18 ` Michał Winiarski
2024-08-14 4:16 ` James Zhu
2024-08-14 4:20 ` James Zhu
2024-08-14 19:29 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61efe587-9a7a-063c-a388-eed9f51958d4@amd.com \
--to=jamesz@amd.com \
--cc=James.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox