From: Tomi Sarvela <tomi.p.sarvela@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable
Date: Thu, 12 Jan 2017 12:44:52 +0200 [thread overview]
Message-ID: <6210983.aPMEN6q1QC@fractal.fi.intel.com> (raw)
In-Reply-To: <20170112103347.GQ16278@nuc-i3427.alporthouse.com>
On Thursday, 12 January 2017 10:33:47 EET Chris Wilson wrote:
> On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote:
> > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT
> > offsets used by the GuC are mappable"), we're asserting that GuC
> > firmware is in the GuC mappable range.
> > Except we're not pinning the object with bias, which means it's
> > possible to trigger this assert. Let's add a proper bias.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
>
> My spider sense is tingling....
>
> CI has been reporting a suspend freeze with guc enabled. Tomi?
DRM-Tip kernels on Skylake from commit 8e6dfee and onwards
(drm-tip: 2017y-01m-05d-16h-48m-32s UTC integration manifest)
get into infinite suspend with following options turned on:
i915.enable_guc_submission=1 i915.enable_guc_loading=1
With this patch the testhost i6700K survived dozen rounds of
igt@gem_exec_suspend@basic-s3, without it the first run hangs the
machine.
Tested-by: Tomi Sarvela <tomi.p.sarvela@intel.com>
Best regards,
Tomi Sarvela
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-12 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 15:17 [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable Michał Winiarski
2017-01-11 15:28 ` Chris Wilson
2017-01-11 19:53 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-01-11 22:26 ` [PATCH] " Daniele Ceraolo Spurio
2017-01-12 10:33 ` Chris Wilson
2017-01-12 10:44 ` Tomi Sarvela [this message]
2017-01-12 10:55 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6210983.aPMEN6q1QC@fractal.fi.intel.com \
--to=tomi.p.sarvela@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox