From: Thomas Zimmermann <tzimmermann@suse.de>
To: Jani Nikula <jani.nikula@intel.com>,
dri-devel@lists.freedesktop.org,
maarten.lankhorst@linux.intel.com,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@redhat.com>,
simona.vetter@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 0/3] drm: replace drm_print.h includes from headers with a forward declaration
Date: Mon, 27 Oct 2025 13:13:57 +0100 [thread overview]
Message-ID: <625c965e-e875-4d5b-88a3-0adaed39fbd6@suse.de> (raw)
In-Reply-To: <2266c3955cd1153aabc909fd3b7a4f019a549989@intel.com>
Hi
Am 27.10.25 um 13:04 schrieb Jani Nikula:
> On Mon, 27 Oct 2025, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> Hi,
>>
>> for the series
>>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Thanks!
>
>> Some thoughts: Consider merging patches 1 and 2 OR split off the change
>> to ttm_resource.h from patch 3. Doing the latter would make a revert of
>> the forward declaration easier in case some trees stop building. Feel
>> free to put everything into drm-misc-next if that still compiles then.
> I'm sorry, I don't understand what you're getting at. The series is
> bisectable, and in the first patch the indirect source of drm_print.h is
> drm_mm.h, and in the third patch it's ttm_resource.h.
Sorry, I misread that. Then maybe consider splitting off those header
changes into separate patches. They could be reverted by themselves
easily without touching all the drivers. Your choice.
Best regards
Thomas
>
> BR,
> Jani.
>
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2025-10-27 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 9:48 [PATCH v2 0/3] drm: replace drm_print.h includes from headers with a forward declaration Jani Nikula
2025-10-22 9:48 ` [PATCH v2 1/3] drm/mm: replace drm_print.h include " Jani Nikula
2025-10-22 9:48 ` [PATCH v2 2/3] drm/buddy: " Jani Nikula
2025-10-22 9:48 ` [PATCH v2 3/3] drm/ttm: " Jani Nikula
2025-10-22 11:27 ` ✓ i915.CI.BAT: success for drm: replace drm_print.h includes from headers with a forward declaration (rev2) Patchwork
2025-10-22 14:14 ` ✓ i915.CI.Full: " Patchwork
2025-10-27 11:21 ` [PATCH v2 0/3] drm: replace drm_print.h includes from headers with a forward declaration Thomas Zimmermann
2025-10-27 12:04 ` Jani Nikula
2025-10-27 12:13 ` Thomas Zimmermann [this message]
2025-10-27 13:10 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=625c965e-e875-4d5b-88a3-0adaed39fbd6@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona.vetter@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox