From: John Harrison <John.C.Harrison@Intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: failure for Update whitelist support for new hardware
Date: Fri, 14 Jun 2019 11:17:25 -0700 [thread overview]
Message-ID: <62936bb8-63bd-827b-6e31-2a5adbc2c09a@Intel.com> (raw)
In-Reply-To: <69a355d5-e7a7-9d81-179a-14ba9c984bdb@linux.intel.com>
On 6/14/2019 10:19, Tvrtko Ursulin wrote:
>
> Read-back of 0x20ec (GEN9_CS_DEBUG_MODE1) seems to be causing issues.
> It could be put on the wo_register list if appropriate. And/or made
> RING_FORCE_TO_NONPRIV_RW.
>
> However now I realize that handling of new whitelisting modes is
> missing from the selftest altogether. All RING_FORCE_TO_NONPRIV_RD and
> RING_FORCE_TO_NONPRIV_WR probably need explicit handling there - first
> ones to check they cannot be written to, and skip read-back on the
> second one.
>
> Regards,
>
> Tvrtko
It looks like there are multiple issues.
I think the quickest/simplest option right now is to drop a bunch of the
ICL updates (because there are too many for the current 12 slot maximum)
and to drop the problematic CFL updates.
The only changes that are urgently needed are the HUC status registers.
Unfortunately, they are read-only entries. So the self-test will need to
be updated to cope with those. Not sure what it can do though. Do we
just skip read-only entries? The test can't know what a valid value to
read back is.
The rest we can put back in later on once all the other issues have been
resolved.
John.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-14 18:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 0:28 [PATCH 0/4] Update whitelist support for new hardware Robert M. Fosha
2019-06-14 0:28 ` [PATCH 1/4] drm/i915: Support flags in whitlist WAs Robert M. Fosha
2019-06-14 6:48 ` Tvrtko Ursulin
2019-06-18 1:13 ` John Harrison
2019-06-18 6:51 ` Tvrtko Ursulin
2019-06-14 0:28 ` [PATCH 2/4] drm/i915: Support whitelist workarounds on all engines Robert M. Fosha
2019-06-14 6:50 ` Tvrtko Ursulin
2019-06-14 0:28 ` [PATCH 3/4] drm/i915: Add whitelist workarounds for CFL Robert M. Fosha
2019-06-14 6:54 ` Tvrtko Ursulin
2019-06-14 0:28 ` [PATCH 4/4] drm/i915: Add whitelist workarounds for ICL Robert M. Fosha
2019-06-14 6:57 ` Tvrtko Ursulin
2019-06-14 1:09 ` ✗ Fi.CI.CHECKPATCH: warning for Update whitelist support for new hardware Patchwork
2019-06-14 14:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-06-14 17:19 ` Tvrtko Ursulin
2019-06-14 18:17 ` John Harrison [this message]
2019-06-14 18:22 ` Chris Wilson
2019-06-14 18:44 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62936bb8-63bd-827b-6e31-2a5adbc2c09a@Intel.com \
--to=john.c.harrison@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox