Re: [Intel-gfx] [PATCH] drm/i915/dg2: Drop force_probe requirement

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 09/11/2022 00:13, Matt Roper wrote:
> DG2 has been very usable for a while now, and all of the uapi changes
> related to fundamental platform usage have been finalized.  Recent CI
> results have also been healthy, so we're ready to drop the force_probe
> requirement and enable the platform by default.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> 
> There was some recent offline discussion questioning whether we'd fully
> identified the root cause of some historic CI failures, or whether it
> was possible we might still have a bug lurking somewhere causing
> sporadic failures.  Let's use this patch to centralize discussion about
> any remaining concerns and make sure they're addressed before we apply
> this.

The two main issues were analysed and I am satisfied that they are 
either very sporadic and with impact limited to i915/DG2, or sporadic 
with impact limited to a small subset of DG2 functionality. Furthermore, 
there are already fixes for both which seem most probably will be merged 
inside the 6.2 fixes window. Therefore I agree that we can proceed with 
dropping the force_probe protection. I also understand our upstream 
maintainer has acked the plan to finish up in the fixes window.

Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

>   drivers/gpu/drm/i915/i915_pci.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 211913be40ce..0866300243aa 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1078,7 +1078,6 @@ static const struct intel_device_info dg2_info = {
>   	XE_LPD_FEATURES,
>   	.__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
>   			       BIT(TRANSCODER_C) | BIT(TRANSCODER_D),
> -	.require_force_probe = 1,
>   };
>   
>   static const struct intel_device_info ats_m_info = {