From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, <dri-devel@lists.freedesktop.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid
Date: Tue, 10 May 2022 15:06:05 +0530 [thread overview]
Message-ID: <661e3a21-e538-0a77-e3ba-3bd1058187e7@intel.com> (raw)
In-Reply-To: <bfd06d64235393012b2f3626d5764350de5f5321.1652097712.git.jani.nikula@intel.com>
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Regards,
Ankit
On 5/9/2022 5:33 PM, Jani Nikula wrote:
> We'll need to propagate drm_edid everywhere.
>
> v2: Fix checkpatch warning on superfluous parens
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index e3ff0f31a614..61551ce0db88 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2598,20 +2598,20 @@ vtb_for_each_detailed_block(const u8 *ext, detailed_cb *cb, void *closure)
> cb((const struct detailed_timing *)(det_base + 18 * i), closure);
> }
>
> -static void
> -drm_for_each_detailed_block(const struct edid *edid, detailed_cb *cb, void *closure)
> +static void drm_for_each_detailed_block(const struct drm_edid *drm_edid,
> + detailed_cb *cb, void *closure)
> {
> struct drm_edid_iter edid_iter;
> const u8 *ext;
> int i;
>
> - if (edid == NULL)
> + if (!drm_edid)
> return;
>
> for (i = 0; i < EDID_DETAILED_TIMINGS; i++)
> - cb(&(edid->detailed_timings[i]), closure);
> + cb(&drm_edid->edid->detailed_timings[i], closure);
>
> - drm_edid_iter_begin(edid, &edid_iter);
> + drm_edid_iter_begin(drm_edid->edid, &edid_iter);
> drm_edid_iter_for_each(ext, &edid_iter) {
> switch (*ext) {
> case CEA_EXT:
> @@ -2650,7 +2650,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid)
> if (drm_edid->edid->revision >= 4) {
> bool ret = false;
>
> - drm_for_each_detailed_block(drm_edid->edid, is_rb, &ret);
> + drm_for_each_detailed_block(drm_edid, is_rb, &ret);
> return ret;
> }
>
> @@ -2677,7 +2677,7 @@ drm_gtf2_hbreak(const struct drm_edid *drm_edid)
> {
> const struct detailed_timing *descriptor = NULL;
>
> - drm_for_each_detailed_block(drm_edid->edid, find_gtf2, &descriptor);
> + drm_for_each_detailed_block(drm_edid, find_gtf2, &descriptor);
>
> BUILD_BUG_ON(offsetof(typeof(*descriptor), data.other_data.data.range.formula.gtf2.hfreq_start_khz) != 12);
>
> @@ -2689,7 +2689,7 @@ drm_gtf2_2c(const struct drm_edid *drm_edid)
> {
> const struct detailed_timing *descriptor = NULL;
>
> - drm_for_each_detailed_block(drm_edid->edid, find_gtf2, &descriptor);
> + drm_for_each_detailed_block(drm_edid, find_gtf2, &descriptor);
>
> BUILD_BUG_ON(offsetof(typeof(*descriptor), data.other_data.data.range.formula.gtf2.c) != 13);
>
> @@ -2701,7 +2701,7 @@ drm_gtf2_m(const struct drm_edid *drm_edid)
> {
> const struct detailed_timing *descriptor = NULL;
>
> - drm_for_each_detailed_block(drm_edid->edid, find_gtf2, &descriptor);
> + drm_for_each_detailed_block(drm_edid, find_gtf2, &descriptor);
>
> BUILD_BUG_ON(offsetof(typeof(*descriptor), data.other_data.data.range.formula.gtf2.m) != 14);
>
> @@ -2713,7 +2713,7 @@ drm_gtf2_k(const struct drm_edid *drm_edid)
> {
> const struct detailed_timing *descriptor = NULL;
>
> - drm_for_each_detailed_block(drm_edid->edid, find_gtf2, &descriptor);
> + drm_for_each_detailed_block(drm_edid, find_gtf2, &descriptor);
>
> BUILD_BUG_ON(offsetof(typeof(*descriptor), data.other_data.data.range.formula.gtf2.k) != 16);
>
> @@ -2725,7 +2725,7 @@ drm_gtf2_2j(const struct drm_edid *drm_edid)
> {
> const struct detailed_timing *descriptor = NULL;
>
> - drm_for_each_detailed_block(drm_edid->edid, find_gtf2, &descriptor);
> + drm_for_each_detailed_block(drm_edid, find_gtf2, &descriptor);
>
> BUILD_BUG_ON(offsetof(typeof(*descriptor), data.other_data.data.range.formula.gtf2.j) != 17);
>
> @@ -3265,7 +3265,7 @@ static int add_inferred_modes(struct drm_connector *connector,
> };
>
> if (version_greater(drm_edid->edid, 1, 0))
> - drm_for_each_detailed_block(drm_edid->edid, do_inferred_modes, &closure);
> + drm_for_each_detailed_block(drm_edid, do_inferred_modes, &closure);
>
> return closure.modes;
> }
> @@ -3342,7 +3342,7 @@ static int add_established_modes(struct drm_connector *connector,
> }
>
> if (version_greater(edid, 1, 0))
> - drm_for_each_detailed_block(drm_edid->edid, do_established_modes,
> + drm_for_each_detailed_block(drm_edid, do_established_modes,
> &closure);
>
> return modes + closure.modes;
> @@ -3397,7 +3397,7 @@ static int add_standard_modes(struct drm_connector *connector,
> }
>
> if (version_greater(drm_edid->edid, 1, 0))
> - drm_for_each_detailed_block(drm_edid->edid, do_standard_modes,
> + drm_for_each_detailed_block(drm_edid, do_standard_modes,
> &closure);
>
> /* XXX should also look for standard codes in VTB blocks */
> @@ -3477,7 +3477,7 @@ add_cvt_modes(struct drm_connector *connector, const struct drm_edid *drm_edid)
> };
>
> if (version_greater(drm_edid->edid, 1, 2))
> - drm_for_each_detailed_block(drm_edid->edid, do_cvt_mode, &closure);
> + drm_for_each_detailed_block(drm_edid, do_cvt_mode, &closure);
>
> /* XXX should also look for CVT codes in VTB blocks */
>
> @@ -3536,7 +3536,7 @@ static int add_detailed_modes(struct drm_connector *connector,
> closure.preferred =
> (drm_edid->edid->features & DRM_EDID_FEATURE_PREFERRED_TIMING);
>
> - drm_for_each_detailed_block(drm_edid->edid, do_detailed_mode, &closure);
> + drm_for_each_detailed_block(drm_edid, do_detailed_mode, &closure);
>
> return closure.modes;
> }
> @@ -4838,7 +4838,7 @@ static int get_monitor_name(const struct drm_edid *drm_edid, char name[13])
> if (!drm_edid || !name)
> return 0;
>
> - drm_for_each_detailed_block(drm_edid->edid, monitor_name, &edid_name);
> + drm_for_each_detailed_block(drm_edid, monitor_name, &edid_name);
> for (mnl = 0; edid_name && mnl < 13; mnl++) {
> if (edid_name[mnl] == 0x0a)
> break;
> @@ -5559,7 +5559,7 @@ static void drm_get_monitor_range(struct drm_connector *connector,
> if (!version_greater(drm_edid->edid, 1, 1))
> return;
>
> - drm_for_each_detailed_block(drm_edid->edid, get_monitor_range,
> + drm_for_each_detailed_block(drm_edid, get_monitor_range,
> &info->monitor_range);
>
> DRM_DEBUG_KMS("Supported Monitor Refresh rate range is %d Hz - %d Hz\n",
next prev parent reply other threads:[~2022-05-10 9:36 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 12:02 [Intel-gfx] [PATCH v2 00/25] drm/edid: introduce struct drm_edid Jani Nikula
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 01/25] drm/edid: use else-if in CTA extension parsing Jani Nikula
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 02/25] drm/edid: convert drm_for_each_detailed_block() to edid iter Jani Nikula
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 03/25] drm/edid: add struct drm_edid container Jani Nikula
2022-05-10 6:26 ` Nautiyal, Ankit K
2022-05-16 8:11 ` Jani Nikula
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 04/25] drm/edid: start propagating drm_edid to lower levels Jani Nikula
2022-05-10 6:23 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 05/25] drm/edid: keep propagating drm_edid to display info Jani Nikula
2022-05-10 6:15 ` Nautiyal, Ankit K
2022-05-11 9:21 ` [Intel-gfx] [PATCH v3] " Jani Nikula
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 06/25] drm/edid: propagate drm_edid to drm_edid_to_eld() Jani Nikula
2022-05-10 6:31 ` Nautiyal, Ankit K
2022-05-11 9:23 ` [Intel-gfx] [PATCH v3] " Jani Nikula
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 07/25] drm/edid: convert drm_edid_connector_update() to drm_edid fully Jani Nikula
2022-05-10 6:45 ` Nautiyal, Ankit K
2022-05-11 9:26 ` [Intel-gfx] [PATCH v3] " Jani Nikula
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 08/25] drm/edid: convert struct detailed_mode_closure to drm_edid Jani Nikula
2022-05-10 7:14 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 09/25] drm/edid: convert drm_mode_detailed() " Jani Nikula
2022-05-10 8:57 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 10/25] drm/edid: convert drm_dmt_modes_for_range() " Jani Nikula
2022-05-10 9:04 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 11/25] drm/edid: convert drm_gtf_modes_for_range() " Jani Nikula
2022-05-10 9:05 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 12/25] drm/edid: convert drm_cvt_modes_for_range() " Jani Nikula
2022-05-10 9:11 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 13/25] drm/edid: convert drm_mode_std() and children " Jani Nikula
2022-05-10 9:18 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() " Jani Nikula
2022-05-10 9:22 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 15/25] drm/edid: convert get_monitor_name() " Jani Nikula
2022-05-10 9:29 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() " Jani Nikula
2022-05-10 9:36 ` Nautiyal, Ankit K [this message]
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad() Jani Nikula
2022-05-10 9:55 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation() Jani Nikula
2022-05-10 10:08 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor() Jani Nikula
2022-05-10 10:15 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio() Jani Nikula
2022-05-10 10:17 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid Jani Nikula
2022-05-10 10:21 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 22/25] drm/edid: convert drm_edid_iter_begin() " Jani Nikula
2022-05-10 10:25 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 23/25] drm/edid: add drm_edid helper for drm_update_tile_info() Jani Nikula
2022-05-10 10:28 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 24/25] drm/displayid: convert to drm_edid Jani Nikula
2022-05-10 12:04 ` Nautiyal, Ankit K
2022-05-09 12:03 ` [Intel-gfx] [PATCH v2 25/25] drm/edid: convert version_greater() " Jani Nikula
2022-05-10 12:07 ` Nautiyal, Ankit K
2022-05-09 19:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid (rev3) Patchwork
2022-05-09 19:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-10 6:29 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-05-11 10:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid (rev6) Patchwork
2022-05-11 10:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-11 14:29 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-05-11 17:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid (rev7) Patchwork
2022-05-11 18:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-11 22:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661e3a21-e538-0a77-e3ba-3bd1058187e7@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox