From: Nirmoy Das <nirmoy.das@linux.intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE
Date: Wed, 15 Nov 2023 17:28:57 +0100 [thread overview]
Message-ID: <676ff1ea-f54f-4f0e-8903-2c65aa6170f0@linux.intel.com> (raw)
In-Reply-To: <20231115-eols-v1-1-d47a2f52b807@intel.com>
On 11/15/2023 1:10 PM, Andrzej Hajda wrote:
> Trace requires new-line at the end of message (in opposition to printk),
> otherwise trace dump becomes messy.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index f5899d503e234b..471b7cdc10ba0f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -167,7 +167,7 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
> enum intel_engine_id id;
> intel_wakeref_t wakeref;
>
> - GT_TRACE(gt, "force:%s", str_yes_no(force));
> + GT_TRACE(gt, "force:%s\n", str_yes_no(force));
>
> /* Use a raw wakeref to avoid calling intel_display_power_get early */
> wakeref = intel_runtime_pm_get(gt->uncore->rpm);
>
> ---
> base-commit: 1489bab52c281a869295414031a56506a375b036
> change-id: 20231115-eols-20f9f52cf338
>
> Best regards,
next prev parent reply other threads:[~2023-11-15 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 12:10 [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE Andrzej Hajda
2023-11-15 12:40 ` Janusz Krzysztofik
2023-11-15 16:28 ` Nirmoy Das [this message]
2023-11-15 23:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-11-16 11:45 ` [Intel-gfx] [PATCH] " Andi Shyti
2023-11-16 12:34 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=676ff1ea-f54f-4f0e-8903-2c65aa6170f0@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox