Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-kernel@vger.kernel.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Vitaly Lubart <vitaly.lubart@intel.com>
Subject: Re: [Intel-gfx] [PATCH v8 12/16] mei: gsc: add transition to PXP mode in resume flow
Date: Wed, 7 Sep 2022 12:23:42 -0700	[thread overview]
Message-ID: <67cf39d3-a36c-d495-c788-42734a2b1d14@intel.com> (raw)
In-Reply-To: <20220907155813.1427526-13-tomas.winkler@intel.com>



On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Vitaly Lubart <vitaly.lubart@intel.com>
>
> Added transition to PXP mode in resume flow.
>
> CC: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

This is unchanged from the previously reviewed rev, so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/gsc-me.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
> index 6b22726aed55..75765e4df4ed 100644
> --- a/drivers/misc/mei/gsc-me.c
> +++ b/drivers/misc/mei/gsc-me.c
> @@ -182,11 +182,22 @@ static int __maybe_unused mei_gsc_pm_suspend(struct device *device)
>   static int __maybe_unused mei_gsc_pm_resume(struct device *device)
>   {
>   	struct mei_device *dev = dev_get_drvdata(device);
> +	struct auxiliary_device *aux_dev;
> +	struct mei_aux_device *adev;
>   	int err;
> +	struct mei_me_hw *hw;
>   
>   	if (!dev)
>   		return -ENODEV;
>   
> +	hw = to_me_hw(dev);
> +	aux_dev = to_auxiliary_dev(device);
> +	adev = auxiliary_dev_to_mei_aux_dev(aux_dev);
> +	if (adev->ext_op_mem.start) {
> +		mei_gsc_set_ext_op_mem(hw, &adev->ext_op_mem);
> +		dev->pxp_mode = MEI_DEV_PXP_INIT;
> +	}
> +
>   	err = mei_restart(dev);
>   	if (err)
>   		return err;


  reply	other threads:[~2022-09-07 19:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 15:57 [Intel-gfx] [PATCH v8 00/16] GSC support for XeHP SDV and DG2 Tomas Winkler
2022-09-07 15:57 ` [Intel-gfx] [PATCH v8 01/16] drm/i915/gsc: skip irq initialization if using polling Tomas Winkler
2022-09-07 15:57 ` [Intel-gfx] [PATCH v8 02/16] mei: add kdoc for struct mei_aux_device Tomas Winkler
2022-09-07 18:58   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 03/16] mei: add slow_firmware flag to the mei auxiliary device Tomas Winkler
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 04/16] drm/i915/gsc: add slow_firmware flag to the gsc device definition Tomas Winkler
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 05/16] drm/i915/gsc: add GSC XeHP SDV platform definition Tomas Winkler
2022-09-07 19:02   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 06/16] mei: gsc: use polling instead of interrupts Tomas Winkler
2022-09-07 19:04   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 07/16] mei: gsc: wait for reset thread on stop Tomas Winkler
2022-09-07 19:06   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 08/16] mei: extend timeouts on slow devices Tomas Winkler
2022-09-07 19:12   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 09/16] mei: bus: export common mkhi definitions into a separate header Tomas Winkler
2022-09-07 19:19   ` Ceraolo Spurio, Daniele
2022-09-07 19:48     ` Winkler, Tomas
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 10/16] mei: mkhi: add memory ready command Tomas Winkler
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 11/16] mei: gsc: setup gsc extended operational memory Tomas Winkler
2022-09-07 19:23   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 12/16] mei: gsc: add transition to PXP mode in resume flow Tomas Winkler
2022-09-07 19:23   ` Ceraolo Spurio, Daniele [this message]
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 13/16] mei: drop ready bits check after start Tomas Winkler
2022-09-07 21:23   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 14/16] mei: debugfs: add pxp mode to devstate in debugfs Tomas Winkler
2022-09-07 19:26   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 15/16] drm/i915/gsc: allocate extended operational memory in LMEM Tomas Winkler
2022-09-07 18:24   ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio
2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 16/16] HAX: drm/i915: force INTEL_MEI_GSC on for CI Tomas Winkler
2022-09-07 16:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev3) Patchwork
2022-09-07 16:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-07 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-07 18:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev4) Patchwork
2022-09-07 18:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-07 19:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67cf39d3-a36c-d495-c788-42734a2b1d14@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=airlied@linux.ie \
    --cc=alexander.usyskin@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tomas.winkler@intel.com \
    --cc=vitaly.lubart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox