From: "Souza, Jose" <jose.souza@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Cc: "Pandey, Hariom" <hariom.pandey@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2
Date: Tue, 29 Sep 2020 20:34:19 +0000 [thread overview]
Message-ID: <6880cd26db1ded393d2a0d90dba4e7c4961f0a4a.camel@intel.com> (raw)
In-Reply-To: <20200929203022.GI6112@intel.com>
On Tue, 2020-09-29 at 23:30 +0300, Ville Syrjälä wrote:
> On Tue, Sep 29, 2020 at 08:20:22PM +0000, Souza, Jose wrote:
> > On Tue, 2020-09-29 at 23:02 +0300, Ville Syrjälä wrote:
> > > On Tue, Sep 29, 2020 at 07:33:45PM +0000, Souza, Jose wrote:
> > > > On Tue, 2020-09-29 at 17:41 +0530, Tejas Upadhyay wrote:
> > > > > JSL has update in vswing table for eDP
> > > >
> > > > Would be nice to mention in the commit description why PCH is being used, that would avoid Ville's question.
> > >
> > > If the thing has nothing to do PCH then it should not use the PCH type
> > > for the the check. Instead we should just do the EHL/JSL split.
> >
> > In the first version Matt Roper suggested to use PCH to differentiate between EHL and JSL, Jani also agreed with this solution.This 2 PCHs can only be
> > associate with EHL and JSL respectively, so no downsides here.
>
> The downside is that the code makes no sense on the first glance.
> It's going to generate a "wtf?" exception in the brain and require
> me to take a second look to figure what is going on. Exception
> handling is expensive and shouldn't be needed in cases where it's
> trivial to make the code 100% obvious.
>
Adding a comment on the top of jsl_get_combo_buf_trans() would help?
Otherwise Tejas you will need to rework this then.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-29 20:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 12:11 [Intel-gfx] [PATCH v2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 Tejas Upadhyay
2020-09-29 12:52 ` Ville Syrjälä
2020-09-29 13:17 ` Surendrakumar Upadhyay, TejaskumarX
2020-09-29 17:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-09-29 18:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-29 19:33 ` [Intel-gfx] [PATCH v2] " Souza, Jose
2020-09-29 20:02 ` Ville Syrjälä
2020-09-29 20:20 ` Souza, Jose
2020-09-29 20:30 ` Ville Syrjälä
2020-09-29 20:34 ` Souza, Jose [this message]
2020-09-29 21:01 ` Matt Roper
2020-09-29 21:11 ` Ville Syrjälä
2020-09-29 21:59 ` Ville Syrjälä
2020-09-29 23:38 ` Matt Roper
2020-09-30 10:38 ` Ville Syrjälä
2020-09-30 12:57 ` Jani Nikula
2020-09-30 18:20 ` Matt Roper
2020-09-30 12:31 ` Jani Nikula
2020-09-30 10:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-10-20 5:36 [Intel-gfx] [PATCH V2] " Tejas Upadhyay
2020-11-09 20:54 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6880cd26db1ded393d2a0d90dba4e7c4961f0a4a.camel@intel.com \
--to=jose.souza@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hariom.pandey@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox