Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 08/10] drm/i915: Nuke HAS_FPGA_DBG_UNCLAIMED()/.has_fpga_dbg
Date: Wed, 11 Nov 2026 12:57:17 +0200	[thread overview]
Message-ID: <6bb3d1e896f78a744efa26a6d2f167ac17cec2fd@intel.com> (raw)
In-Reply-To: <20261110184622.1721-9-ville.syrjala@linux.intel.com>

On Tue, 10 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> HAS_FPGA_DBG_UNCLAIMED() and the underlying .has_fpga_dbg device
> flag is now unused. Nuke it all.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_device.c | 8 --------
>  drivers/gpu/drm/i915/display/intel_display_device.h | 2 --
>  2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 69046d0cd5e9..055396f85e4a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -571,7 +571,6 @@ static const struct platform_desc hsw_desc = {
>  	.info = &(const struct intel_display_device_info) {
>  		.has_ddi = 1,
>  		.has_dp_mst = 1,
> -		.has_fpga_dbg = 1,
>  		.has_hotplug = 1,
>  		.has_psr = 1,
>  		.has_psr_hw_tracking = 1,
> @@ -624,7 +623,6 @@ static const struct platform_desc bdw_desc = {
>  	.info = &(const struct intel_display_device_info) {
>  		.has_ddi = 1,
>  		.has_dp_mst = 1,
> -		.has_fpga_dbg = 1,
>  		.has_hotplug = 1,
>  		.has_psr = 1,
>  		.has_psr_hw_tracking = 1,
> @@ -665,7 +663,6 @@ static const struct intel_display_device_info skl_display = {
>  	.dbuf.slice_mask = BIT(DBUF_S1),
>  	.has_ddi = 1,
>  	.has_dp_mst = 1,
> -	.has_fpga_dbg = 1,
>  	.has_hotplug = 1,
>  	.has_ipc = 1,
>  	.has_psr = 1,
> @@ -815,7 +812,6 @@ static const struct platform_desc cml_desc = {
>  	.dbuf.slice_mask = BIT(DBUF_S1), \
>  	.has_dp_mst = 1, \
>  	.has_ddi = 1, \
> -	.has_fpga_dbg = 1, \
>  	.has_hotplug = 1, \
>  	.has_ipc = 1, \
>  	.has_psr = 1, \
> @@ -874,7 +870,6 @@ static const struct platform_desc glk_desc = {
>  	.dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2), \
>  	.has_ddi = 1, \
>  	.has_dp_mst = 1, \
> -	.has_fpga_dbg = 1, \
>  	.has_hotplug = 1, \
>  	.has_ipc = 1, \
>  	.has_psr = 1, \
> @@ -965,7 +960,6 @@ static const struct platform_desc ehl_desc = {
>  	.has_ddi = 1, \
>  	.has_dp_mst = 1, \
>  	.has_dsb = 1, \
> -	.has_fpga_dbg = 1, \
>  	.has_hotplug = 1, \
>  	.has_ipc = 1, \
>  	.has_psr = 1, \
> @@ -1133,7 +1127,6 @@ static const struct platform_desc adl_s_desc = {
>  	.has_ddi = 1,								\
>  	.has_dp_mst = 1,							\
>  	.has_dsb = 1,								\
> -	.has_fpga_dbg = 1,							\
>  	.has_hotplug = 1,							\
>  	.has_ipc = 1,								\
>  	.has_psr = 1,								\
> @@ -1313,7 +1306,6 @@ static const struct platform_desc dg2_desc = {
>  	.has_ddi = 1,								\
>  	.has_dp_mst = 1,							\
>  	.has_dsb = 1,								\
> -	.has_fpga_dbg = 1,							\
>  	.has_hotplug = 1,							\
>  	.has_ipc = 1,								\
>  	.has_psr = 1,								\
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 7121e7cd9512..4f82520ef960 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -134,7 +134,6 @@ struct intel_display_platforms {
>  	func(has_ddi); \
>  	func(has_dp_mst); \
>  	func(has_dsb); \
> -	func(has_fpga_dbg); \
>  	func(has_gmch); \
>  	func(has_hotplug); \
>  	func(has_hti); \
> @@ -177,7 +176,6 @@ struct intel_display_platforms {
>  #define HAS_FBC(__display)		(DISPLAY_RUNTIME_INFO(__display)->fbc_mask != 0)
>  #define HAS_FBC_DIRTY_RECT(__display)	(DISPLAY_VER(__display) >= 30)
>  #define HAS_FBC_SYS_CACHE(__display)	(DISPLAY_VER(__display) >= 35 && !(__display)->platform.dgfx)
> -#define HAS_FPGA_DBG_UNCLAIMED(__display)	(DISPLAY_INFO(__display)->has_fpga_dbg)
>  #define HAS_FW_BLC(__display)		(DISPLAY_VER(__display) >= 3)
>  #define HAS_GMBUS_BURST_READ(__display)	(DISPLAY_VER(__display) >= 10 || (__display)->platform.kabylake)
>  #define HAS_GMBUS_IRQ(__display)	(DISPLAY_VER(__display) >= 4)

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-11-11 10:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 18:46 [PATCH v2 00/10] drm/i915/de: Work towards uncore elimination Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 01/10] drm/i915/de: Introduce dislay->mmio and intel_de_init() Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 02/10] drm/i915/de: Convert intel_de_{read, write}() into vfuncs Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 03/10] drm/i915/de: Introduce mmio read/write templates Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 04/10] drm/i915/de: Eliminate runtime overhead from DMC wakelock on pre-LNL platforms Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 05/10] drm/i915/de: Introduce display->mmio.lock Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 06/10] drm/i915/uncore: Don't meddle with mmio debug upon user forcewake Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 07/10] drm/i915/de: Move unclaimed mmio detection into display code Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 08/10] drm/i915: Nuke HAS_FPGA_DBG_UNCLAIMED()/.has_fpga_dbg Ville Syrjala
2026-11-11 10:57   ` Jani Nikula [this message]
2026-11-10 18:46 ` [PATCH v2 09/10] drm/i915/de: Stop using intel_uncore_{read,write}() Ville Syrjala
2026-11-10 18:46 ` [PATCH v2 10/10] drm/xe: Nuke the intel_uncore_{read, write}() wrappers Ville Syrjala
2026-11-10 19:46 ` ✗ i915.CI.BAT: failure for drm/i915/de: Work towards uncore elimination (rev2) Patchwork
2026-11-10 21:27 ` ✓ i915.CI.BAT: success for drm/i915/de: Work towards uncore elimination (rev3) Patchwork
2026-11-11  6:11 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bb3d1e896f78a744efa26a6d2f167ac17cec2fd@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox