From: "Maxime Ripard" <mripard@kernel.org>
To: "Ville Syrjala" <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Maxime Ripard" <mripard@kernel.org>
Subject: Re: [PATCH 2/2] drm/atomic: WARN about invalid drm_foo_get_state() usage
Date: Mon, 20 Oct 2025 07:29:49 +0000 [thread overview]
Message-ID: <6bccb6ce0672f5b736bb8669060d8005@kernel.org> (raw)
In-Reply-To: <20251017163327.9074-2-ville.syrjala@linux.intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Fri, 17 Oct 2025 19:33:27 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm_{crtc,plane,connector,private_obj}_get_state() must not
> be called after the atomic check phase. At that point the commit
> has been carved in stone and no new objects must be introduced
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2025-10-20 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 16:33 [PATCH 1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() Ville Syrjala
2025-10-17 16:33 ` [PATCH 2/2] drm/atomic: WARN about invalid drm_foo_get_state() usage Ville Syrjala
2025-10-20 7:29 ` Maxime Ripard [this message]
2025-10-28 20:52 ` Ville Syrjälä
2025-10-17 17:36 ` ✗ i915.CI.BAT: failure for series starting with [1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() Patchwork
2025-10-20 7:29 ` [PATCH 1/2] " Maxime Ripard
2025-10-21 14:05 ` ✗ i915.CI.BAT: failure for series starting with [1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() (rev2) Patchwork
2025-10-23 18:07 ` ✓ i915.CI.BAT: success for series starting with [1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() (rev3) Patchwork
2025-10-24 7:12 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bccb6ce0672f5b736bb8669060d8005@kernel.org \
--to=mripard@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox