From: "Souza, Jose" <jose.souza@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"tianjia.zhang@linux.alibaba.com"
<tianjia.zhang@linux.alibaba.com>
Cc: "tianjia.zhang@alibaba.com" <tianjia.zhang@alibaba.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value in intel_atomic_check()
Date: Mon, 3 Aug 2020 19:35:27 +0000 [thread overview]
Message-ID: <6c076128ecda7b48e8a5f1c78eb718026b2cd0ba.camel@intel.com> (raw)
In-Reply-To: <20200802111535.5200-1-tianjia.zhang@linux.alibaba.com>
On Sun, 2020-08-02 at 19:15 +0800, Tianjia Zhang wrote:
> In the case of calling check_digital_port_conflicts() failed, a
> negative error code -EINVAL should be returned.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Fixes: bf5da83e4bd80 ("drm/i915: Move check_digital_port_conflicts() earier")
> Cc: Ville Syrjälä <
> ville.syrjala@linux.intel.com
> >
> Signed-off-by: Tianjia Zhang <
> tianjia.zhang@linux.alibaba.com
> >
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 26996e1839e2..9f3a7ef58aba 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14872,7 +14872,7 @@ static int intel_atomic_check(struct drm_device *dev,
> if (any_ms && !check_digital_port_conflicts(state)) {
> drm_dbg_kms(&dev_priv->drm,
> "rejecting conflicting digital port configuration\n");
> - ret = EINVAL;
> + ret = -EINVAL;
> goto fail;
> }
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-08-03 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 11:15 [Intel-gfx] [PATCH] drm/i915: Fix wrong return value in intel_atomic_check() Tianjia Zhang
2020-08-03 13:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-08-03 13:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-03 16:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-03 19:38 ` Souza, Jose
2020-08-03 19:35 ` Souza, Jose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c076128ecda7b48e8a5f1c78eb718026b2cd0ba.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tianjia.zhang@alibaba.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox