From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 4/4 v2] drm/i915: Never read FORCEWAKE
Date: Sun, 02 Sep 2012 09:41:44 +0100 [thread overview]
Message-ID: <6c3329$5q3u4c@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1346565590-1760-4-git-send-email-ben@bwidawsk.net>
On Sat, 1 Sep 2012 22:59:50 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> The same designer from the previous patch has told us to never read
> FORCEWAKE. We only do this for the POSTING_READ(), so simply change that
> to something within the same cacheline (for no reason in particular
> other than it sounds nice). In the _mt case we can leverage
> the gtfifodbg check for the POSTING_READ.
The first two are Reviewed-by: Chris Wilson <chris@chris-wilson.oc.uk>
The real meat of the change in the second two look good, so
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-09-02 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 5:59 [PATCH 1/4] drm/i915: Extract forcewake ack timeout Ben Widawsky
2012-09-02 5:59 ` [PATCH 2/4] drm/i915: use cpu_relax() in wait_for_atomic Ben Widawsky
2012-09-02 5:59 ` [PATCH 3/4] drm/i915: Change forcewake timeout to 2ms Ben Widawsky
2012-09-02 5:59 ` [PATCH 4/4 v2] drm/i915: Never read FORCEWAKE Ben Widawsky
2012-09-02 8:41 ` Chris Wilson [this message]
2012-09-03 8:30 ` Daniel Vetter
2012-09-03 8:42 ` [PATCH 1/4] drm/i915: Extract forcewake ack timeout Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$5q3u4c@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox