Re: [Intel-gfx] [PULL] gvt-next

["Vivi, Rodrigo" <rodrigo.vivi@intel.com>]

On Thu, 2022-11-17 at 11:02 +0800, Zhenyu Wang wrote:
> On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote:
> > On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
> > > Hi,
> > > 
> > > Here's current accumulated changes in gvt-next. Sorry that I
> > > delayed
> > > to refresh them on time for upstream...It contains mostly kernel
> > > doc,
> > > typo fixes and small code cleanups, as details below.
> > > 
> > > btw, one gvt change for next
> > > https://patchwork.freedesktop.org/patch/511118/
> > > is still pending, I need a backmerge from linus tree e.g with
> > > recent vfio/mdev
> > > consolidate change with gvt and Jason's fix for destroy device,
> > > to apply Zhi's
> > > change cleanly. Pls help on that.
> > > 
> > > Thanks!
> > > ---
> > > The following changes since commit
> > > a6ebd538364b1e9e6048faaafbc0188172ed50c3:
> > > 
> > >   drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://github.com/intel/gvt-linux.git tags/gvt-next-2022-11-11
> > > 
> > > for you to fetch changes up to
> > > 50468ca2e2e1ce882f060a8c263f678affe112db:
> > > 
> > >   drm/i915/gvt: Remove the unused function get_pt_type() (2022-
> > > 11-08 15:34:06 +0800)
> > > 
> > > ----------------------------------------------------------------
> > > gvt-next-2022-11-11
> > > 
> > > - kernel doc fixes
> > > - remove vgpu->released sanity check
> > > - small clean up
> > > 
> > > ----------------------------------------------------------------
> > > Colin Ian King (1):
> > >       drm/i915/reg: Fix spelling mistake "Unsupport" ->
> > > "Unsupported"
> > 
> > dim: d7e4e9579f01 ("drm/i915/reg: Fix spelling mistake "Unsupport"
> > -> "Unsupported""): committer Signed-off-by missing.
> > 
> > could you please fix this before we can merge this pr?
> > 
> 
> That should still be .mailmap issue for Colin's email...
> But could we improve our dim script to grep mailmap in that case? So
> if s-o-b mail is valid
> in mailmap, we should still allow it, right?

Based on what I could verify the commiter signature is really not
there. It looks like you later forced a rebase and while
rebasing you forgot to re-sign everything.

We need to fix this in your tree to avoid propagating that to other
trees later:

From tig view:
Commit:     Zhenyu Wang <zhenyuw@linux.intel.com>
CommitDate: Tue Nov 8 15:04:53 2022 +0800

    drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

    There is a spelling mistake in a gvt_vgpu_err error message. Fix
it.

    Fixes: 695fbc08d80f ("drm/i915/gvt: replace the gvt_err with
gvt_vgpu_err")
    Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
    Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
    Link:
http://patchwork.freedesktop.org/patch/msgid/20220315202449.2952845-1-colin.i.king@gmail.com
    Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>

no signature from you.

> 
> > > 
> > > Jiapeng Chong (4):
> > >       drm/i915/gvt: Fix kernel-doc
> > >       drm/i915/gvt: Fix kernel-doc
> > >       drm/i915/gvt: Fix kernel-doc
> > >       drm/i915/gvt: Remove the unused function get_pt_type()
> > > 
> > > Julia Lawall (1):
> > >       drm/i915/gvt: fix typo in comment
> > > 
> > > Mauro Carvalho Chehab (1):
> > >       drm/i915: gvt: fix kernel-doc trivial warnings
> > > 
> > > Paulo Miguel Almeida (1):
> > >       i915/gvt: remove hardcoded value on crc32_start calculation
> > > 
> > > Zhi Wang (1):
> > >       drm/i915/gvt: remove the vgpu->released and its sanity
> > > check
> > > 
> > > wangjianli (1):
> > >       drm/i915: fix repeated words in comments
> > > 
> > >  drivers/gpu/drm/i915/gvt/aperture_gm.c  | 4 ++--
> > >  drivers/gpu/drm/i915/gvt/cfg_space.c    | 2 +-
> > >  drivers/gpu/drm/i915/gvt/dmabuf.h       | 2 +-
> > >  drivers/gpu/drm/i915/gvt/firmware.c     | 2 +-
> > >  drivers/gpu/drm/i915/gvt/gtt.c          | 9 ++-------
> > >  drivers/gpu/drm/i915/gvt/gvt.h          | 2 --
> > >  drivers/gpu/drm/i915/gvt/handlers.c     | 4 ++--
> > >  drivers/gpu/drm/i915/gvt/kvmgt.c        | 4 ----
> > >  drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> > >  drivers/gpu/drm/i915/gvt/page_track.c   | 2 +-
> > >  drivers/gpu/drm/i915/gvt/vgpu.c         | 6 +++---
> > >  11 files changed, 14 insertions(+), 25 deletions(-)
> > 
> >