public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Improved reporting when GuC fails to load
Date: Wed, 30 Sep 2020 17:38:43 -0700	[thread overview]
Message-ID: <6e127a5b-822d-b50d-c0be-4cab53ddc4d9@intel.com> (raw)
In-Reply-To: <20200925232637.1968039-3-John.C.Harrison@Intel.com>



On 9/25/2020 4:26 PM, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Rather than just saying 'GuC failed to load: -110', actually print out
> the GuC status register and break it down into the individual fields.
>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 31 ++++++++++++++++-------
>   1 file changed, 22 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> index d4a87f4c9421..f9d0907ea1a5 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> @@ -76,6 +76,7 @@ static inline bool guc_ready(struct intel_uncore *uncore, u32 *status)
>   
>   static int guc_wait_ucode(struct intel_uncore *uncore)
>   {
> +	struct drm_device *drm = &uncore->i915->drm;
>   	u32 status;
>   	int ret;
>   
> @@ -90,15 +91,27 @@ static int guc_wait_ucode(struct intel_uncore *uncore)
>   	ret = wait_for(guc_ready(uncore, &status), 100);
>   	DRM_DEBUG_DRIVER("GuC status %#x\n", status);
>   
> -	if ((status & GS_BOOTROM_MASK) == GS_BOOTROM_RSA_FAILED) {
> -		DRM_ERROR("GuC firmware signature verification failed\n");
> -		ret = -ENOEXEC;
> -	}
> -
> -	if ((status & GS_UKERNEL_MASK) == GS_UKERNEL_EXCEPTION) {
> -		DRM_ERROR("GuC firmware exception. EIP: %#x\n",
> -			  intel_uncore_read(uncore, SOFT_SCRATCH(13)));
> -		ret = -ENXIO;
> +	if (ret) {
> +		drm_err(drm, "GuC load failed: status = 0x%08X\n", status);
> +		drm_err(drm, "GuC load failed: status: Reset = %d, "
> +			"BootROM = 0x%02X, UKernel = 0x%02X, "
> +			"MIA = 0x%02X, Auth = 0x%02X\n",
> +			REG_FIELD_GET(GS_MIA_IN_RESET, status),
> +			REG_FIELD_GET(GS_BOOTROM_MASK, status),
> +			REG_FIELD_GET(GS_UKERNEL_MASK, status),
> +			REG_FIELD_GET(GS_MIA_MASK, status),
> +			REG_FIELD_GET(GS_AUTH_STATUS_MASK, status));
> +
> +		if ((status & GS_BOOTROM_MASK) == GS_BOOTROM_RSA_FAILED) {
> +			drm_err(drm, "GuC firmware signature verification failed\n");
> +			ret = -ENOEXEC;
> +		}
> +
> +		if ((status & GS_UKERNEL_MASK) == GS_UKERNEL_EXCEPTION) {
> +			drm_err(drm, "GuC firmware exception. EIP: %#x\n",
> +				intel_uncore_read(uncore, SOFT_SCRATCH(13)));
> +			ret = -ENXIO;
> +		}
>   	}
>   
>   	return ret;

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-10-01  0:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 23:26 [Intel-gfx] [PATCH 0/4] drm/i915/guc: Update to GuC v49 John.C.Harrison
2020-09-25 23:26 ` [Intel-gfx] [PATCH 1/4] drm/i915/guc: Update to use firmware v49.0.1 John.C.Harrison
2020-10-01  0:24   ` Daniele Ceraolo Spurio
2020-09-25 23:26 ` [Intel-gfx] [PATCH 2/4] drm/i915/guc: Improved reporting when GuC fails to load John.C.Harrison
2020-10-01  0:38   ` Daniele Ceraolo Spurio [this message]
2020-09-25 23:26 ` [Intel-gfx] [PATCH 3/4] drm/i915/guc: Clear pointers on free John.C.Harrison
2020-10-09 21:43   ` Daniele Ceraolo Spurio
2020-09-25 23:26 ` [Intel-gfx] [PATCH 4/4] drm/i915/uc: turn on GuC/HuC auto mode by default John.C.Harrison
2020-09-25 23:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Update to GuC v49 Patchwork
2020-09-26  0:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-26  1:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-09-21 17:54 [Intel-gfx] [PATCH 0/4] " John.C.Harrison
2020-09-21 17:54 ` [Intel-gfx] [PATCH 2/4] drm/i915/guc: Improved reporting when GuC fails to load John.C.Harrison
2020-09-22  0:33   ` Daniele Ceraolo Spurio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e127a5b-822d-b50d-c0be-4cab53ddc4d9@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=Intel-GFX@Lists.FreeDesktop.Org \
    --cc=John.C.Harrison@Intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox