From: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915/display/psr2: Mark as updated all planes that intersect with pipe_clip
Date: Mon, 26 Jul 2021 21:15:32 +0000 [thread overview]
Message-ID: <6e6234022c2d4ff0bc17f6c66783d8d3@intel.com> (raw)
In-Reply-To: <20210717011227.204494-2-jose.souza@intel.com>
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of José
> Roberto de Souza
> Sent: Friday, July 16, 2021 6:12 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 2/4] drm/i915/display/psr2: Mark as updated all
> planes that intersect with pipe_clip
>
> Without this planes that were added by intel_psr2_sel_fetch_update() that
> intersect with pipe damaged area will not have skl_program_plane() and
> intel_psr2_program_plane_sel_fetch()
> called, causing panel to not be properly updated.
>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index d436490ab28c6..1c41042841fb1 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1699,6 +1699,7 @@ int intel_psr2_sel_fetch_update(struct
> intel_atomic_state *state,
> sel_fetch_area = &new_plane_state->psr2_sel_fetch_area;
> sel_fetch_area->y1 = inter.y1 - new_plane_state-
> >uapi.dst.y1;
> sel_fetch_area->y2 = inter.y2 - new_plane_state-
> >uapi.dst.y1;
> + crtc_state->update_planes |= BIT(plane->id);
> }
>
> skip_sel_fetch_set_loop:
> --
> 2.32.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-26 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 1:12 [Intel-gfx] [PATCH 1/4] drm/i915/display: Disable FBC when PSR2 is enabled for xelpd platforms José Roberto de Souza
2021-07-17 1:12 ` [Intel-gfx] [PATCH 2/4] drm/i915/display/psr2: Mark as updated all planes that intersect with pipe_clip José Roberto de Souza
2021-07-26 21:15 ` Srivatsa, Anusha [this message]
2021-07-17 1:12 ` [Intel-gfx] [PATCH 3/4] drm/i915/display/psr2: Fix cursor updates using legacy apis José Roberto de Souza
2021-07-26 21:19 ` Srivatsa, Anusha
2021-07-17 1:12 ` [Intel-gfx] [PATCH 4/4] drm/i915/display/psr2: Force a PSR exit in the frontbuffer modification flushes José Roberto de Souza
2021-07-26 21:23 ` Srivatsa, Anusha
2021-07-17 2:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/4] drm/i915/display: Disable FBC when PSR2 is enabled for xelpd platforms Patchwork
2021-07-17 2:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-17 12:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-26 23:11 ` Souza, Jose
2021-07-21 18:04 ` [Intel-gfx] [PATCH 1/4] " Srivatsa, Anusha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e6234022c2d4ff0bc17f6c66783d8d3@intel.com \
--to=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox