From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH v2 3/6] drm/i915/lspcon: change signature of lspcon_detect_hdr_capability()
Date: Tue, 4 Feb 2025 15:58:40 +0200 [thread overview]
Message-ID: <6f249f5c537a16a6762faddffd6a95cbf61cf077.1738677489.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1738677489.git.jani.nikula@intel.com>
Switch from struct intel_lspcon to struct intel_digital_port to unify,
and return the value so the caller doesn't have to look at
lspcon->hdr_detected directly.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 +---
drivers/gpu/drm/i915/display/intel_lspcon.c | 5 ++++-
drivers/gpu/drm/i915/display/intel_lspcon.h | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index ef182ef574f7..2db7741c25bd 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5844,7 +5844,6 @@ intel_dp_connector_register(struct drm_connector *connector)
struct intel_display *display = to_intel_display(connector->dev);
struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector));
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
- struct intel_lspcon *lspcon = &dig_port->lspcon;
int ret;
ret = intel_connector_register(connector);
@@ -5867,8 +5866,7 @@ intel_dp_connector_register(struct drm_connector *connector)
* efficiently and streamlined.
*/
if (lspcon_init(dig_port)) {
- lspcon_detect_hdr_capability(lspcon);
- if (lspcon->hdr_supported)
+ if (lspcon_detect_hdr_capability(dig_port))
drm_connector_attach_hdr_output_metadata_property(connector);
}
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index e54aad8a5f7f..2dd2b700b0f3 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -121,8 +121,9 @@ static u32 get_hdr_status_reg(struct intel_lspcon *lspcon)
return DPCD_PARADE_LSPCON_HDR_STATUS;
}
-void lspcon_detect_hdr_capability(struct intel_lspcon *lspcon)
+bool lspcon_detect_hdr_capability(struct intel_digital_port *dig_port)
{
+ struct intel_lspcon *lspcon = &dig_port->lspcon;
struct intel_dp *intel_dp = lspcon_to_intel_dp(lspcon);
struct intel_display *display = to_intel_display(intel_dp);
u8 hdr_caps;
@@ -138,6 +139,8 @@ void lspcon_detect_hdr_capability(struct intel_lspcon *lspcon)
drm_dbg_kms(display->drm, "LSPCON capable of HDR\n");
lspcon->hdr_supported = true;
}
+
+ return lspcon->hdr_supported;
}
static enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h
index 4c8ba3ddbac4..18cc15e5221d 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.h
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
@@ -17,7 +17,7 @@ struct intel_lspcon;
bool lspcon_init(struct intel_digital_port *dig_port);
bool intel_lspcon_active(struct intel_digital_port *dig_port);
-void lspcon_detect_hdr_capability(struct intel_lspcon *lspcon);
+bool lspcon_detect_hdr_capability(struct intel_digital_port *dig_port);
void lspcon_resume(struct intel_digital_port *dig_port);
void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon);
void lspcon_write_infoframe(struct intel_encoder *encoder,
--
2.39.5
next prev parent reply other threads:[~2025-02-04 13:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:58 [PATCH v2 0/6] drm/i915/lspcon: interface cleanups Jani Nikula
2025-02-04 13:58 ` [PATCH v2 1/6] drm/i915/hdmi: move declarations for hsw_read/write_infoframe() to the right place Jani Nikula
2025-02-04 22:55 ` Rodrigo Vivi
2025-02-04 13:58 ` [PATCH v2 2/6] drm/i915/lspcon: add intel_lspcon_active() and use it Jani Nikula
2025-02-04 22:55 ` Rodrigo Vivi
2025-02-04 13:58 ` Jani Nikula [this message]
2025-02-04 22:57 ` [PATCH v2 3/6] drm/i915/lspcon: change signature of lspcon_detect_hdr_capability() Rodrigo Vivi
2025-02-04 13:58 ` [PATCH v2 4/6] drm/i915/lspcon: change signature of lspcon_wait_pcon_mode() Jani Nikula
2025-02-04 22:58 ` Rodrigo Vivi
2025-02-05 17:53 ` Jani Nikula
2025-02-04 13:58 ` [PATCH v2 5/6] drm/i915/lspcon: remove dp_to_lspcon(), hide enc_to_intel_lspcon() Jani Nikula
2025-02-04 22:59 ` Rodrigo Vivi
2025-02-04 13:58 ` [PATCH v2 6/6] drm/i915/lspcon: rename interfaces to intel_lspcon_* to unify Jani Nikula
2025-02-04 22:59 ` Rodrigo Vivi
2025-02-04 18:31 ` ✗ Fi.CI.SPARSE: warning for drm/i915/lspcon: interface cleanups (rev2) Patchwork
2025-02-04 18:50 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-05 8:33 ` Jani Nikula
2025-02-05 14:02 ` Ravali, JupallyX
2025-02-05 11:37 ` ✓ i915.CI.BAT: success " Patchwork
2025-02-05 15:45 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f249f5c537a16a6762faddffd6a95cbf61cf077.1738677489.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox