From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove flush_scheduled_work() from live_execlists
Date: Fri, 23 Sep 2022 12:32:24 +0200 [thread overview]
Message-ID: <6f789a18-76be-ebc6-a20a-fa63963e9498@linux.intel.com> (raw)
In-Reply-To: <20220630125716.50835-1-tvrtko.ursulin@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
On 6/30/2022 2:57 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> There are ongoing efforts to remove usages of flush_scheduled_work() from
> drivers in order to avoid several cases of potentential problems when
> flushing is done from certain contexts.
>
> Remove the call from the live_execlists selftest. Its purpose was to be
> thorough and sync with the execlists capture state handling, but that is
> not strictly required for the test to function and can be removed.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> ---
> drivers/gpu/drm/i915/gt/selftest_execlists.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> index 09f8cd2d0e2c..e62d089257ae 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> @@ -85,8 +85,6 @@ static int wait_for_reset(struct intel_engine_cs *engine,
> break;
> } while (time_before(jiffies, timeout));
>
> - flush_scheduled_work();
> -
> if (rq->fence.error != -EIO) {
> pr_err("%s: hanging request %llx:%lld not reset\n",
> engine->name,
next prev parent reply other threads:[~2022-09-23 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 12:57 [Intel-gfx] [PATCH] drm/i915/selftests: Remove flush_scheduled_work() from live_execlists Tvrtko Ursulin
2022-06-30 17:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-07-01 7:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-23 10:32 ` Das, Nirmoy [this message]
2022-09-23 11:00 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f789a18-76be-ebc6-a20a-fa63963e9498@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox