Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	zack.rusin@broadcom.com, lyude@redhat.com, kherbst@redhat.com,
	jani.nikula@linux.intel.com, nouveau@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: Rework TTMs busy handling
Date: Tue, 09 Jan 2024 09:14:18 +0100	[thread overview]
Message-ID: <70484d976d3af4286652a6b26ed8783a9362f403.camel@linux.intel.com> (raw)
In-Reply-To: <20240109074729.3646-1-christian.koenig@amd.com>

Hi, Christian

On Tue, 2024-01-09 at 08:47 +0100, Christian König wrote:
> Hi guys,
> 
> I'm trying to make this functionality a bit more useful for years now
> since we multiple reports that behavior of drivers can be suboptimal
> when multiple placements be given.
> 
> So basically instead of hacking around the TTM behavior in the driver
> once more I've gone ahead and changed the idle/busy placement list
> into idle/busy placement flags. This not only saves a bunch of code,
> but also allows setting some placements as fallback which are used if
> allocating from the preferred ones didn't worked.
> 
> Zack pointed out that some removed VMWGFX code was brought back
> because
> of rebasing, fixed in this version.
> 
> Intel CI seems to be happy with those patches, so any more comments?

Looks like Xe changes are missing? (xe is now in drm-tip).

I also have some doubts about the naming "idle" vs "busy", since an
elaborate eviction mechanism would probably at some point want to check
for gpu idle vs gpu busy, and this might create some confusion moving
forward for people confusing busy as in memory overcommit with busy as
in gpu activity.

I can't immediately think of something better, though.

/Thomas


> 
> Regards,
> Christian.
> 
> 


  parent reply	other threads:[~2024-01-09  8:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09  7:47 Rework TTMs busy handling Christian König
2024-01-09  7:47 ` [PATCH 1/5] drm/vmwgfx: remove vmw_vram_gmr_placement Christian König
2024-01-09  7:47 ` [PATCH 2/5] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
2024-01-09  9:17   ` Thomas Hellström
2024-01-09  7:47 ` [PATCH 3/5] drm/ttm: replace busy placement with flags v5 Christian König
2024-01-09 17:29   ` Zack Rusin
2024-01-09  7:47 ` [PATCH 4/5] drm/ttm: improve idle/busy handling v2 Christian König
2024-01-09  7:47 ` [PATCH 5/5] drm/amdgpu: use GTT only as fallback for VRAM|GTT Christian König
2024-01-09  8:14 ` Thomas Hellström [this message]
2024-01-09  8:34   ` Rework TTMs busy handling Christian König
2024-01-10  9:03     ` Michel Dänzer
2024-01-09  8:18 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/vmwgfx: remove vmw_vram_gmr_placement Patchwork
2024-01-09  8:18 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-09  8:31 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-09 14:09 ` ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-01-26 14:09 Rework TTMs busy handling Christian König
2024-01-12 12:51 Christian König
2024-01-16  9:57 ` Christian König
2024-01-17  3:13   ` Zack Rusin
2024-01-04 15:05 Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70484d976d3af4286652a6b26ed8783a9362f403.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=kherbst@redhat.com \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox