From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Chris Wilson <chris.p.wilson@intel.com>,
linux-doc@vger.kernel.org, Rodrigo Vivi <rodrigo.vivi@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gt: document TLB cache invalidation functions
Date: Fri, 5 Aug 2022 10:24:25 +0100 [thread overview]
Message-ID: <7156b3bd-69d7-de53-dd2b-96e82a8cf0f7@linux.intel.com> (raw)
In-Reply-To: <Yuzd9Ysc3BDQHuSW@alfio.lan>
On 05/08/2022 10:08, Andi Shyti wrote:
> Hi Randy,
>
>>> +/**
>>> + * intel_gt_invalidate_tlb_full - do full TLB cache invalidation
>>> + * @gt: GT structure
>>
>> In multiple places (here and below) it would be nice to know what a
>> GT structure is. I looked thru multiple C and header files yesterday
>> and didn't find any comments about it.
>>
>> Just saying that @gt is a GT structure isn't very helpful, other
>> than making kernel-doc shut up.
>
> the 'gt' belongs to the drivers/gpu/drm/i915/gt/ subsystem and
> it's widely used a throughout i915.
>
> I think it's inappropriate to describe it just here. On the other
> hand I agree that a better documentation is required for the GT
> itself where other parts can point to.
Yeah agreed there is no point of copy pasting some explanation all over
the place. Could we just do s/GT structure/struct intel_gt/, or "pointer
to struct intel_gt to operate on", would that be good enough?
Regards,
Tvrtko
next prev parent reply other threads:[~2022-08-05 9:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 7:37 [Intel-gfx] [PATCH v3 0/3] Move TLB invalidation code for its own file and document it Mauro Carvalho Chehab
2022-08-04 7:37 ` [Intel-gfx] [PATCH v3 1/3] drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb() Mauro Carvalho Chehab
2022-08-04 8:18 ` Tvrtko Ursulin
2022-08-08 16:37 ` Andi Shyti
2022-08-08 19:04 ` Rodrigo Vivi
2022-08-08 23:09 ` Andi Shyti
2022-08-09 0:15 ` Vivi, Rodrigo
2022-08-09 6:29 ` Mauro Carvalho Chehab
2022-08-04 7:37 ` [Intel-gfx] [PATCH v3 2/3] drm/i915/gt: Move TLB invalidation to its own file Mauro Carvalho Chehab
2022-08-04 7:37 ` [Intel-gfx] [PATCH v3 3/3] drm/i915/gt: document TLB cache invalidation functions Mauro Carvalho Chehab
2022-08-04 19:00 ` Randy Dunlap
2022-08-05 9:08 ` Andi Shyti
2022-08-05 9:24 ` Tvrtko Ursulin [this message]
2022-08-05 10:30 ` Mauro Carvalho Chehab
2022-08-08 16:58 ` Andi Shyti
2022-08-04 8:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Move TLB invalidation code for its own file and document it (rev4) Patchwork
2022-08-04 8:12 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-04 8:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-04 10:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7156b3bd-69d7-de53-dd2b-96e82a8cf0f7@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=airlied@linux.ie \
--cc=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@intel.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rodrigo.vivi@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox