Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>,
	<intel-xe@lists.freedesktop.org>,
	 <intel-gfx@lists.freedesktop.org>
Cc: <matthew.d.roper@intel.com>
Subject: Re: [PATCH 2/4] drm/i915/xe3lpd: Increase max_h max_v for PSR
Date: Thu, 24 Oct 2024 18:34:48 +0530	[thread overview]
Message-ID: <71c9ad2c-90ea-4f02-bd40-cbe86577d131@intel.com> (raw)
In-Reply-To: <20241024035552.94363-3-suraj.kandpal@intel.com>


On 10/24/2024 9:25 AM, Suraj Kandpal wrote:
> Spec states that PSR max active is same as max pipe active values.
> Now that each pipe supports 6k resolution increasing max_h and
> max_v for PSR too.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_psr.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 3b20325b3f6a..8981a180285e 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1451,7 +1451,11 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
>   		return false;
>   	}
>   
> -	if (DISPLAY_VER(display) >= 12) {
> +	if (DISPLAY_VER(dev_priv) >= 30) {
> +		psr_max_h = 6144;
> +		psr_max_v = 4096;

As per Bspec:69885 from XE2LPD+ the max size for PSR2 is pipe active 
size, so psr_max_v should have been 4096 even earlier.

Perhaps need to change even for earlier platform.

Regards,

Ankit

> +		max_bpp = 30;
> +	} else if (DISPLAY_VER(dev_priv) >= 12) {
>   		psr_max_h = 5120;
>   		psr_max_v = 3200;
>   		max_bpp = 30;

  reply	other threads:[~2024-10-24 13:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24  3:55 [PATCH 0/4] Add 6k resolution support for a single CRTC Suraj Kandpal
2024-10-24  3:55 ` [PATCH 1/4] drm/i915/xe3lpd: Increase resolution for plane to support 6k Suraj Kandpal
2024-10-24 11:46   ` Nautiyal, Ankit K
2024-10-24 19:48     ` Matt Roper
2024-10-25  4:05       ` Nautiyal, Ankit K
2024-10-24  3:55 ` [PATCH 2/4] drm/i915/xe3lpd: Increase max_h max_v for PSR Suraj Kandpal
2024-10-24 13:04   ` Nautiyal, Ankit K [this message]
2024-10-24 19:59     ` Matt Roper
2024-10-24  3:55 ` [PATCH 3/4] drm/i914/xe3lpd: Increase bigjoiner limitations Suraj Kandpal
2024-10-24 11:51   ` Nautiyal, Ankit K
2024-10-24  3:55 ` [PATCH 4/4] drm/i915/xe3lpd: Prune modes for YUV420 Suraj Kandpal
2024-10-24 12:20   ` Nautiyal, Ankit K
2024-10-24  9:22 ` ✓ Fi.CI.BAT: success for Add 6k resolution support for a single CRTC (rev2) Patchwork
2024-10-24  9:23 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-10-24 11:24 ` ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-10-15  6:10 [PATCH 0/4] Add 6k resolution support for a single CRTC Suraj Kandpal
2024-10-15  6:10 ` [PATCH 2/4] drm/i915/xe3lpd: Increase max_h max_v for PSR Suraj Kandpal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71c9ad2c-90ea-4f02-bd40-cbe86577d131@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox