From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [RFC 04/10] drm/i915: Move intel_engine_context_in/out into intel_lrc.c
Date: Tue, 22 May 2018 14:02:39 +0100 [thread overview]
Message-ID: <73572df1-75cc-da64-0952-458fcfae478e@linux.intel.com> (raw)
In-Reply-To: <152699316118.10297.10062641623825717901@mail.alporthouse.com>
On 22/05/2018 13:46, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-05-22 13:30:14)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Intel_lrc.c is the only caller and so to avoid some header file ordering
>> issues in future patches move these two over there.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Expectation was that we would be using these in guc. Brief highlight of
> how the plan changed?
"Let's postpone the disaster" ? :) I am talking about header file
ordering disaster, not GuC, so someone doesn't get me wrong.
But in actuality, since we have postponed GuC until Gen11, and there we
get a different kind of GuC, the kind where will be no way for i915 to
have visibility on when a context get in and out, and which physical
engines. So I think we really won't have a need for these hooks in the
Gen11 GuC code.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-22 13:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 12:30 [RFC v5 00/10] Per-context and per-client engine busyness Tvrtko Ursulin
2018-05-22 12:30 ` [RFC 01/10] drm/i915: Store engine backpointer in the intel_context Tvrtko Ursulin
2018-05-22 12:30 ` [RFC 02/10] drm/i915: Include i915_scheduler.h from i915_gem_context.h Tvrtko Ursulin
2018-05-22 12:44 ` Chris Wilson
2018-05-22 12:52 ` Mika Kuoppala
2018-05-22 12:30 ` [RFC 03/10] drm/i915: Forward declare struct intel_context Tvrtko Ursulin
2018-05-22 12:44 ` Chris Wilson
2018-05-22 12:30 ` [RFC 04/10] drm/i915: Move intel_engine_context_in/out into intel_lrc.c Tvrtko Ursulin
2018-05-22 12:46 ` Chris Wilson
2018-05-22 13:02 ` Tvrtko Ursulin [this message]
2018-05-22 12:30 ` [RFC 05/10] drm/i915: Track per-context engine busyness Tvrtko Ursulin
2018-05-22 12:30 ` [RFC 06/10] drm/i915: Expose list of clients in sysfs Tvrtko Ursulin
2018-05-22 12:30 ` [RFC 07/10] drm/i915: Update client name on context create Tvrtko Ursulin
2018-05-22 12:30 ` [RFC 08/10] drm/i915: Expose per-engine client busyness Tvrtko Ursulin
2018-05-22 12:30 ` [RFC 09/10] drm/i915: Add sysfs toggle to enable per-client engine stats Tvrtko Ursulin
2018-05-22 12:30 ` [RFC 10/10] drm/i915: Allow clients to query own per-engine busyness Tvrtko Ursulin
2018-05-22 12:54 ` ✗ Fi.CI.CHECKPATCH: warning for Per-context and per-client engine busyness (rev6) Patchwork
2018-05-22 12:58 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-22 13:10 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-22 18:15 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73572df1-75cc-da64-0952-458fcfae478e@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox