From: Markus Elfring <Markus.Elfring@web.de>
To: "Alejandro W. Sior" <aho@sior.be>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix NULL pointer dereference in intel_vgpu_reg_rw_edid()
Date: Tue, 8 Sep 2020 17:47:34 +0200 [thread overview]
Message-ID: <743818af-fa38-e31a-1780-84a6a7e72e25@web.de> (raw)
> In the function intel_vgpu_reg_rw_edid of gvt/kvmgt.c, pos can get equal to NULL for GPUs that do not
> properly support EDID. …
* I propose to reconsider the previous patch subject once more.
* Did the script “checkpatch.pl” point any adjustment possibilities out
for the change description?
> This patch solves this problem by …
Would an imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n151
> … to a nagative value, …
Please avoid a typo here.
I suggest to add the tag “Fixes” to the commit message.
Regards,
Markus
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-09-08 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 15:47 Markus Elfring [this message]
2020-09-08 18:11 ` [Intel-gfx] [PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid() Alejandro Sior
2020-09-11 5:39 ` Zhenyu Wang
2020-09-12 7:02 ` Aho Sior
2020-09-08 18:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-09-08 18:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-08 19:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-11 6:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid() (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743818af-fa38-e31a-1780-84a6a7e72e25@web.de \
--to=markus.elfring@web.de \
--cc=aho@sior.be \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox