From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: handle more rounding
Date: Wed, 6 Apr 2022 19:41:03 +0200 [thread overview]
Message-ID: <7684092d-7d86-98d5-b90b-bd7b9db37f74@linux.intel.com> (raw)
In-Reply-To: <20220406173023.1039107-1-matthew.auld@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
On 4/6/2022 7:30 PM, Matthew Auld wrote:
> Ensure we account for potential rounding up of lmem objects.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5485
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_migrate.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i915/gt/selftest_migrate.c
> index c9c4f391c5cc..cca3b0db83c9 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_migrate.c
> @@ -621,13 +621,15 @@ static int perf_copy_blt(void *arg)
>
> for (i = 0; i < ARRAY_SIZE(sizes); i++) {
> struct drm_i915_gem_object *src, *dst;
> + size_t sz;
> int err;
>
> src = create_init_lmem_internal(gt, sizes[i], true);
> if (IS_ERR(src))
> return PTR_ERR(src);
>
> - dst = create_init_lmem_internal(gt, sizes[i], false);
> + sz = src->base.size;
> + dst = create_init_lmem_internal(gt, sz, false);
> if (IS_ERR(dst)) {
> err = PTR_ERR(dst);
> goto err_src;
> @@ -640,7 +642,7 @@ static int perf_copy_blt(void *arg)
> dst->mm.pages->sgl,
> I915_CACHE_NONE,
> i915_gem_object_is_lmem(dst),
> - sizes[i]);
> + sz);
>
> i915_gem_object_unlock(dst);
> i915_gem_object_put(dst);
next prev parent reply other threads:[~2022-04-06 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 17:30 [Intel-gfx] [PATCH] drm/i915/selftests: handle more rounding Matthew Auld
2022-04-06 17:41 ` Das, Nirmoy [this message]
2022-04-06 19:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-04-07 0:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7684092d-7d86-98d5-b90b-bd7b9db37f74@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox