public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Hellstrom, Thomas" <thomas.hellstrom@intel.com>
To: "Newsome, Jasmine" <jasmine.newsome@intel.com>,
	"Intel-GFX@Lists.FreeDesktop.Org"
	<Intel-GFX@Lists.FreeDesktop.Org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Use local pointer ttm for __i915_ttm_move
Date: Fri, 10 Dec 2021 13:32:34 +0000	[thread overview]
Message-ID: <772c62338bc2d5bc65fad13b8dcfd4ac5dd71169.camel@intel.com> (raw)
In-Reply-To: <20211209000533.1670512-1-jasmine.newsome@intel.com>

On Wed, 2021-12-08 at 16:05 -0800, Jasmine Newsome wrote:
> Using local pointer ttm as argument in  __i915_ttm_move
> instead of bo->ttm, as local pointer was previously assigned
> to bo->ttm in function. This will make code a bit more readable.
> 
> Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>


> ---
>  drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> index 80df9f592407..56b6573b5c93 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> @@ -763,7 +763,7 @@ int i915_ttm_move(struct ttm_buffer_object *bo,
> bool evict,
>                         return PTR_ERR(dep);
>                 }
>  
> -               migration_fence = __i915_ttm_move(bo, clear, dst_mem,
> bo->ttm,
> +               migration_fence = __i915_ttm_move(bo, clear, dst_mem,
> ttm,
>                                                   dst_rsgt, true,
> dep);
>                 dma_fence_put(dep);
>         }

----------------------------------------------------------------------
Intel Sweden AB
Registered Office: Isafjordsgatan 30B, 164 40 Kista, Stockholm, Sweden
Registration Number: 556189-6027

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

       reply	other threads:[~2021-12-10 13:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211209000533.1670512-1-jasmine.newsome@intel.com>
2021-12-10 13:32 ` Hellstrom, Thomas [this message]
2022-01-04 20:36 [Intel-gfx] [PATCH] drm/i915/gem: Use local pointer ttm for __i915_ttm_move Jasmine Newsome
  -- strict thread matches above, loose matches on Subject: below --
2021-12-09 16:23 Jasmine Newsome
2021-12-09  6:33 Jasmine Newsome
2021-12-03 21:49 Jasmine Newsome
2021-12-08 10:10 ` Thomas Hellström (Intel)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=772c62338bc2d5bc65fad13b8dcfd4ac5dd71169.camel@intel.com \
    --to=thomas.hellstrom@intel.com \
    --cc=Intel-GFX@Lists.FreeDesktop.Org \
    --cc=jasmine.newsome@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox