From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/gsc: add support for GSC proxy interrupt
Date: Thu, 4 May 2023 06:11:27 +0000 [thread overview]
Message-ID: <785d80d9841820aa8fc49d16d55e69099ed672c7.camel@intel.com> (raw)
In-Reply-To: <20230502163854.317653-5-daniele.ceraolospurio@intel.com>
On Tue, 2023-05-02 at 09:38 -0700, Ceraolo Spurio, Daniele wrote:
> The GSC notifies us of a proxy request via the HECI2 interrupt. The
> interrupt must be enabled both in the HECI layer and in our usual gt irq
> programming; for the latter, the interrupt is enabled via the same enable
> register as the GSC CS, but it does have its own mask register. When the
> interrupt is received, we also need to de-assert it in both layers.
>
> The handling of the proxy request is deferred to the same worker that we
> use for GSC load. New flags have been added to distinguish between the
> init case and the proxy interrupt.
>
> v2: Make sure not to set the reset bit when enabling/disabling the GSC
> interrupts, fix defines (Alan)
>
> v3: rebase on proxy status register check
>
alan:snip
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
next prev parent reply other threads:[~2023-05-04 6:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 16:38 [Intel-gfx] [PATCH v3 0/4] drm/i915: Add support for MTL GSC SW Proxy Daniele Ceraolo Spurio
2023-05-02 16:38 ` [Intel-gfx] [PATCH v3 1/4] drm/i915/mtl: Define GSC Proxy component interface Daniele Ceraolo Spurio
2023-05-04 5:26 ` Teres Alexis, Alan Previn
2023-05-02 16:38 ` [Intel-gfx] [PATCH v3 2/4] mei: gsc_proxy: add gsc proxy driver Daniele Ceraolo Spurio
2023-05-04 5:42 ` Teres Alexis, Alan Previn
2023-05-02 16:38 ` [Intel-gfx] [PATCH v3 3/4] drm/i915/gsc: add initial support for GSC proxy Daniele Ceraolo Spurio
2023-05-04 6:01 ` Teres Alexis, Alan Previn
2023-05-02 16:38 ` [Intel-gfx] [PATCH v3 4/4] drm/i915/gsc: add support for GSC proxy interrupt Daniele Ceraolo Spurio
2023-05-04 6:11 ` Teres Alexis, Alan Previn [this message]
2023-05-02 17:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for MTL GSC SW Proxy (rev3) Patchwork
2023-05-02 17:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-02 17:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-02 19:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=785d80d9841820aa8fc49d16d55e69099ed672c7.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox