From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Use all physical engines for i915_active
Date: Mon, 21 Oct 2019 18:06:43 +0100 [thread overview]
Message-ID: <7ac50613-703a-42cd-eb30-83597a6902c8@linux.intel.com> (raw)
In-Reply-To: <20191021162146.1686-1-chris@chris-wilson.co.uk>
On 21/10/2019 17:21, Chris Wilson wrote:
> i915_active must track over any engine, so expand the selftest to
> iterate over all uabi engines.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_active.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_active.c b/drivers/gpu/drm/i915/selftests/i915_active.c
> index 268192b5613b..96513a7d4739 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_active.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_active.c
> @@ -79,7 +79,6 @@ __live_active_setup(struct drm_i915_private *i915)
> struct intel_engine_cs *engine;
> struct i915_sw_fence *submit;
> struct live_active *active;
> - enum intel_engine_id id;
> unsigned int count = 0;
> int err = 0;
>
> @@ -97,7 +96,7 @@ __live_active_setup(struct drm_i915_private *i915)
> if (err)
> goto out;
>
> - for_each_engine(engine, i915, id) {
> + for_each_uabi_engine(engine, i915) {
> struct i915_request *rq;
>
> rq = i915_request_create(engine->kernel_context);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-21 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 16:21 [PATCH] drm/i915/selftests: Use all physical engines for i915_active Chris Wilson
2019-10-21 17:06 ` Tvrtko Ursulin [this message]
2019-10-21 17:17 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-21 22:35 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ac50613-703a-42cd-eb30-83597a6902c8@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox