Re: [Intel-gfx] [PATCH] drm/i915/guc: Improve debug message on context reset notification

[John Harrison <john.c.harrison@intel.com>]

On 1/31/2023 13:44, Michal Wajdeczko wrote:
> Just recently we switched over to new GuC oriented log macros but in
> the meantime yet another message was added that we missed to update.
>
> While around improve that new message by adding engine name and use
> existing helpers to check for context state.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index 53f3ed3244d5..be495e657d66 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -4660,9 +4660,10 @@ static void guc_handle_context_reset(struct intel_guc *guc,
>   {
>   	trace_intel_context_reset(ce);
>   
> -	drm_dbg(&guc_to_gt(guc)->i915->drm, "Got GuC reset of 0x%04X, exiting = %d, banned = %d\n",
> -		ce->guc_id.id, test_bit(CONTEXT_EXITING, &ce->flags),
> -		test_bit(CONTEXT_BANNED, &ce->flags));
> +	guc_dbg(guc, "Got context reset notification: 0x%04X on %s, exiting = %s, banned = %s\n",
> +		ce->guc_id.id, ce->engine->name,
> +		str_yes_no(intel_context_is_exiting(ce)),
> +		str_yes_no(intel_context_is_banned(ce)));
>   
>   	if (likely(intel_context_is_schedulable(ce))) {
>   		capture_error_state(guc, ce);