Re: [Intel-gfx] [PATCH 2/5] drm/i915/guc: Print status register when waiting for GuC to load

["Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>]

On 4/14/2023 5:57 PM, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> If the GuC load is taking an excessively long time, the wait loop
> currently prints the GT frequency. Extend that to include the GuC
> status as well so we can see if the GuC is actually making progress or
> not.
>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> index 0ff088a5e51a8..364d0d546ec82 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> @@ -191,8 +191,10 @@ static int guc_wait_ucode(struct intel_guc *guc)
>   		if (!ret || !success)
>   			break;
>   
> -		guc_dbg(guc, "load still in progress, count = %d, freq = %dMHz\n",
> -			count, intel_rps_read_actual_frequency(&uncore->gt->rps));
> +		guc_dbg(guc, "load still in progress, count = %d, freq = %dMHz, status = 0x%08X [0x%02X/%02X]\n",
> +			count, intel_rps_read_actual_frequency(&uncore->gt->rps), status,
> +			REG_FIELD_GET(GS_BOOTROM_MASK, status),
> +			REG_FIELD_GET(GS_UKERNEL_MASK, status));
>   	}
>   	after = ktime_get();
>   	delta = ktime_sub(after, before);