Re: [Intel-gfx] [PATCH 0/7] drm/i915/fbc: FBC frontbuffer stuff

["Kahola, Mika" <mika.kahola@intel.com>]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville
> Syrjala
> Sent: Tuesday, March 15, 2022 4:00 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 0/7] drm/i915/fbc: FBC frontbuffer stuff
> 
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Avoid all the FBC frontbuffer vs. atomic commit raciness by not doing any FBC
> nukes while a flip is pending. Allows us to remove the last locks from the i9xx
> plane code.
> 
> I also want to explore the idea of always generating DSB batches for pipe
> commits and just excuting them on the CPU if no DSB hardware is available.
> Locked register writes (and any register reads, of which there are still a few)
> prevent me from doing that.
> 

As far as I have understood, what we try to achieve with this series looks ok to me.

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Ville Syrjälä (7):
>   drm/i915/fbc: Eliminate possible_framebuffer_bits
>   drm/i915/fbc: Streamline frontbuffer busy bits handling
>   drm/i915/fbc: Skip nuke when flip is pending
>   drm/i915: Remove remaining locks from i9xx plane udpates
>   drm/i915/fbc: Remove intel_fbc_global_disable()
>   drm/i915/fbc: Introduce intel_fbc_sanitize()
>   drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer
>     flush
> 
>  drivers/gpu/drm/i915/display/i9xx_plane.c    | 12 ---
>  drivers/gpu/drm/i915/display/intel_display.c |  4 +-
>  drivers/gpu/drm/i915/display/intel_fbc.c     | 88 +++++++++-----------
>  drivers/gpu/drm/i915/display/intel_fbc.h     |  2 +-
>  drivers/gpu/drm/i915/i915_suspend.c          |  4 -
>  5 files changed, 44 insertions(+), 66 deletions(-)
> 
> --
> 2.34.1