Re: [PATCH v5 06/10] drm/i915/hotplug: add helpers to track HPDs can generate PME

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 11 Sep 2026, Vinod Govindapillai <vinod.govindapillai@intel.com> wrote:
> As NVL+ devices can generate PME from HPDs, introduce a flag to
> keep track of such a capability and helper functions to access
> this flag. The plan is, this flag will be set to true from pm runtime
> suspend if PME is enabled and this flag will cleared on early runtime
> resume unconditionally. This is a place holder for the flag and later
> on this flag will be used for conditional IRQ resets and to decide
> whether to do HPD polling.

What's the rationale for duplicating the state in a flag? Why can't you
use intel_display_rpm_pme_enabled() and have a single point of truth?
This would dodge the extra error path clearing too.

I don't understand.

BR,
Jani.

>
> Bspec: 52979, 52980, 68857, 68867, 68970
> Assisted-by: GitHub_Copilot:claude-opus-5
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_core.h |  2 ++
>  drivers/gpu/drm/i915/display/intel_hotplug.c      | 10 ++++++++++
>  drivers/gpu/drm/i915/display/intel_hotplug.h      |  3 +++
>  3 files changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h
> index c80b4a2f74f9..b3a396800798 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_core.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
> @@ -220,6 +220,8 @@ struct intel_hotplug {
>  	 * cue to ignore the long HPDs and can be set / unset using debugfs.
>  	 */
>  	bool ignore_long_hpd;
> +
> +	bool can_generate_pme;
>  };
>  
>  struct intel_vbt_data {
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
> index 970aa95ee344..b24c9f360e24 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> @@ -846,6 +846,16 @@ static void i915_hpd_poll_init_work(struct work_struct *work)
>  	}
>  }
>  
> +void intel_hpd_set_pme_capable(struct intel_display *display, bool can_generate_pme)
> +{
> +	display->hotplug.can_generate_pme = can_generate_pme;
> +}
> +
> +bool intel_hpd_can_generate_pme(struct intel_display *display)
> +{
> +	return display->hotplug.can_generate_pme;
> +}
> +
>  /**
>   * intel_hpd_poll_enable - enable polling for connectors with hpd
>   * @display: display device instance
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.h b/drivers/gpu/drm/i915/display/intel_hotplug.h
> index edc41c9d3d65..c57e30f8366b 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug.h
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.h
> @@ -35,4 +35,7 @@ void intel_hpd_enable_detection_work(struct intel_display *display);
>  void intel_hpd_disable_detection_work(struct intel_display *display);
>  bool intel_hpd_schedule_detection(struct intel_display *display);
>  
> +void intel_hpd_set_pme_capable(struct intel_display *display, bool can_generate_pme);
> +bool intel_hpd_can_generate_pme(struct intel_display *display);
> +
>  #endif /* __INTEL_HOTPLUG_H__ */

-- 
Jani Nikula, Intel