Re: [PATCH 3/4] drm/i915/gvt: drop dependency on intel_display_types.h

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 1/28/2026 8:29 PM, Jani Nikula wrote:
> Avoid even accidental use of display details by dropping the include of
> intel_display_types.h. We'll still have to include intel_dpll_mgt.h for


s/intel_dpll_mgt.h/intel_dpll_mgr.h

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> the DPLL IDs, but at least the surface is smaller.
>
> Add duplicate defines of pipe_name() and port_name() to avoid depending
> on display. They're trivial enough to be acceptable.
>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/i915/gvt/handlers.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index 383b04160559..6f860c320afc 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -46,10 +46,10 @@
>   #include "display/intel_crt_regs.h"
>   #include "display/intel_cursor_regs.h"
>   #include "display/intel_display_regs.h"
> -#include "display/intel_display_types.h"
>   #include "display/intel_dmc_regs.h"
>   #include "display/intel_dp_aux_regs.h"
>   #include "display/intel_dpio_phy.h"
> +#include "display/intel_dpll_mgr.h"
>   #include "display/intel_fbc.h"
>   #include "display/intel_fdi_regs.h"
>   #include "display/intel_pps_regs.h"
> @@ -79,6 +79,9 @@
>   #define PCH_PP_OFF_DELAYS _MMIO(0xc720c)
>   #define PCH_PP_DIVISOR _MMIO(0xc7210)
>   
> +#define pipe_name(p) ((p) + 'A')
> +#define port_name(p) ((p) + 'A')
> +
>   unsigned long intel_gvt_get_device_type(struct intel_gvt *gvt)
>   {
>   	struct drm_i915_private *i915 = gvt->gt->i915;