From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [Intel-gfx 1/1] drm/i915/guc: Don't update engine busyness stats too frequently
Date: Mon, 20 Jun 2022 09:38:53 +0100 [thread overview]
Message-ID: <82e0a95b-717a-e502-35bf-2d2994831321@linux.intel.com> (raw)
In-Reply-To: <f1c2cd183ba15ca11607e7e4c21c6f436b4315be.camel@intel.com>
On 17/06/2022 22:43, Teres Alexis, Alan Previn wrote:
>
>>>> Not updating the driver state in park will not negatively impact
>>>> accuracy in some scenarios? That needs to balanced against the
>>>> questions whether or not there are real world scenarios impacted by
>>>> the update cost or it is just for IGT.
>>>
> If i understand it correctly (how its calculated), no. not capturing on every park/unpark
> does not mean less accuracy. Umesh mentioned to verify that with igt@perf-pmu@accuracy
> tests
Okay you moved it from guc_update_engine_gt_clks to
intel_guc_busyness_park to work around the loss of accuracy. I almost
missed it since patch itself has not changelog. Works for me if Umesh
approves it is correct.
Regards,
Tvrtko
next prev parent reply other threads:[~2022-06-20 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 17:27 [Intel-gfx] [Intel-gfx 0/1] drm/i915/guc: Don't update engine busyness stats too frequently Alan Previn
2022-06-11 17:27 ` [Intel-gfx] [Intel-gfx 1/1] " Alan Previn
2022-06-13 8:10 ` Tvrtko Ursulin
2022-06-14 1:10 ` Umesh Nerlige Ramappa
2022-06-14 7:07 ` Tvrtko Ursulin
2022-06-15 18:59 ` Lucas De Marchi
2022-06-16 16:41 ` Tvrtko Ursulin
2022-06-17 16:38 ` Teres Alexis, Alan Previn
2022-06-17 21:43 ` Teres Alexis, Alan Previn
2022-06-20 8:38 ` Tvrtko Ursulin [this message]
2022-06-13 23:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Don't update engine busyness stats too frequently (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e0a95b-717a-e502-35bf-2d2994831321@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox