From: Matthew Auld <matthew.auld@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove leftover vma->obj->pages_pin_count on insert/remove
Date: Tue, 15 Oct 2019 11:22:20 +0100 [thread overview]
Message-ID: <83cbb75c-07eb-47df-511a-1448955a1daf@intel.com> (raw)
In-Reply-To: <20191015100155.10376-1-chris@chris-wilson.co.uk>
On 15/10/2019 11:01, Chris Wilson wrote:
> We now do the page pin count upfront in vma_get_pages/vma_put_pages, so
> that we do the allocations before we enter the vm->mutex. Then our vma
> page references are tracking in vma->pages_count and the extra
> obj->pages_pin_count being performed in i915_vma_insert/i915_vma_remove
> is redundant, and worse throws off the shrinker's logic on when it can
> free an object by unbinding it.
>
Could you also add Reported-by: Daniele Ceraolo Spurio
<daniele.ceraolospurio@intel.com>
> Reported-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-15 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 10:01 [PATCH] drm/i915: Remove leftover vma->obj->pages_pin_count on insert/remove Chris Wilson
2019-10-15 10:22 ` Matthew Auld [this message]
2019-10-15 13:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cbb75c-07eb-47df-511a-1448955a1daf@intel.com \
--to=matthew.auld@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox