Re: [Intel-gfx] [PATCH] drm/i915: Fix coredump of perma-pinned vmas

[Matthew Auld <matthew.auld@intel.com>]

On 08/12/2021 08:22, Thomas Hellström wrote:
> When updating the error capture code and introducing vma snapshots,
> we introduced code to hold the vma in memory while capturing it,
> calling i915_active_acquire_if_busy(). Now that function isn't relevant
> for perma-pinned vmas and caused important vmas to be dropped from the
> coredump. Like for example the GuC log.
> 
> Fix this by instead requiring those vmas to be pinned while capturing.
> 
> Tested by running the initial subtests of the gem_exec_capture igt test
> with GuC submission enabled and verifying that a GuC log blob appears
> in the output.
> 
> Fixes: ff20afc4cee7 ("drm/i915: Update error capture code to avoid using the current vma state")
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Reported-by: John Harrison <John.C.Harrison@Intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>