From: "Souza, Jose" <jose.souza@intel.com>
To: "Mun, Gwan-gyeong" <gwan-gyeong.mun@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/psr: Add sink not reliable check to intel_psr_work()
Date: Fri, 12 Mar 2021 13:37:58 +0000 [thread overview]
Message-ID: <85d3edee2ca1da2ed4cf09fe6451b6a079b2fd51.camel@intel.com> (raw)
In-Reply-To: <20210312133430.1478156-1-gwan-gyeong.mun@intel.com>
On Fri, 2021-03-12 at 15:34 +0200, Gwan-gyeong Mun wrote:
> If the sink state is not reliable, it does not need to wait for
> PSR "IDLE state" for re-enabling PSR. And it should not try to re-enable
> PSR.
>
> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index cd434285e3b7..7f555407de06 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1686,6 +1686,9 @@ static void intel_psr_work(struct work_struct *work)
> if (READ_ONCE(intel_dp->psr.irq_aux_error))
> intel_psr_handle_irq(intel_dp);
>
>
>
>
> + if (intel_dp->psr.sink_not_reliable)
> + goto unlock;
I can't think any scenario that this will hit.
Before set sink_not_reliable PSR will be disabled so it will be caught in the first check of intel_psr_work().
> +
> /*
> * We have to make sure PSR is ready for re-enable
> * otherwise it keeps disabled until next full enable/disable cycle.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-03-12 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 13:34 [Intel-gfx] [PATCH] drm/i915/display/psr: Add sink not reliable check to intel_psr_work() Gwan-gyeong Mun
2021-03-12 13:37 ` Souza, Jose [this message]
2021-03-13 20:01 ` Mun, Gwan-gyeong
2021-03-16 14:38 ` Souza, Jose
2021-03-12 14:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-03-12 15:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d3edee2ca1da2ed4cf09fe6451b6a079b2fd51.camel@intel.com \
--to=jose.souza@intel.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox